Update specification of ADDRESS01#1284
Merged
Merged
Conversation
Contributor
|
Hi @tolvmannen, thanks for this! For your information, all PRs must be done against the develop branch (I changed that for you just now). |
matsduf
reviewed
Jul 3, 2024
matsduf
reviewed
Jul 11, 2024
matsduf
requested changes
Jul 12, 2024
matsduf
left a comment
Contributor
There was a problem hiding this comment.
In general it looks good.
matsduf
reviewed
Jul 29, 2024
matsduf
reviewed
Aug 22, 2024
matsduf
reviewed
Aug 23, 2024
matsduf
reviewed
Aug 28, 2024
Contributor
|
@marc-vanderwal, please review. |
matsduf
reviewed
Aug 30, 2024
matsduf
previously approved these changes
Aug 30, 2024
Merge develop branch into master (Zonemaster/Zonemaster)
matsduf
requested changes
Sep 12, 2025
matsduf
left a comment
Contributor
There was a problem hiding this comment.
Just some minor comments remain.
matsduf
reviewed
Sep 12, 2025
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
matsduf
approved these changes
Sep 19, 2025
tgreenx
previously approved these changes
Oct 30, 2025
matsduf
requested changes
Nov 10, 2025
matsduf
left a comment
Contributor
There was a problem hiding this comment.
I have a change request. I think that all addresses should be listed in the output, also the globally reachable addresses. That is especially important when there is a mix.
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
matsduf
previously approved these changes
Nov 11, 2025
tgreenx
reviewed
Nov 13, 2025
Comment on lines
+43
to
+50
| | Message Tag | Level | Arguments | Message ID for message tag | | ||
| |:--------------------------------|:---------|:----------|:-------------------------------------------------------------------------------------| | ||
| | A01_ADDR_NOT_GLOBALLY_REACHABLE | ERROR | ns_list | IP address not listed as globally reachable: "{ns_list}". | | ||
| | A01_DOCUMENTATION_ADDR | ERROR | ns_list | IP address intended for documentation purposes: "{ns_list}". | | ||
| | A01_GLOBALLY_REACHABLE_ADDR | INFO | ns_list | Globally reachable IP address: "{ns_list}". | | ||
| | A01_LOCAL_USE_ADDR | ERROR | ns_list | IP address intended for local use on network or service provider level: "{ns_list}". | | ||
| | A01_NO_GLOBALLY_REACHABLE_ADDR | ERROR | | None of the name servers IP addresses are listed as globally reachable. | | ||
| | A01_NO_NAME_SERVERS_FOUND | CRITICAL | | No name servers found. | |
Contributor
There was a problem hiding this comment.
@matsduf @tolvmannen Now I wonder why we do not use ns_ip_list for these message tags. The test case and message IDs specifically care about IP addresses only. Wouldn't it then be best to show only that?
Suggested change
| | Message Tag | Level | Arguments | Message ID for message tag | | |
| |:--------------------------------|:---------|:----------|:-------------------------------------------------------------------------------------| | |
| | A01_ADDR_NOT_GLOBALLY_REACHABLE | ERROR | ns_list | IP address not listed as globally reachable: "{ns_list}". | | |
| | A01_DOCUMENTATION_ADDR | ERROR | ns_list | IP address intended for documentation purposes: "{ns_list}". | | |
| | A01_GLOBALLY_REACHABLE_ADDR | INFO | ns_list | Globally reachable IP address: "{ns_list}". | | |
| | A01_LOCAL_USE_ADDR | ERROR | ns_list | IP address intended for local use on network or service provider level: "{ns_list}". | | |
| | A01_NO_GLOBALLY_REACHABLE_ADDR | ERROR | | None of the name servers IP addresses are listed as globally reachable. | | |
| | A01_NO_NAME_SERVERS_FOUND | CRITICAL | | No name servers found. | | |
| | Message Tag | Level | Arguments | Message ID for message tag | | |
| |:--------------------------------|:---------|:----------|:-----------------------------------------------------------------------------------------------| | |
| | A01_ADDR_NOT_GLOBALLY_REACHABLE | ERROR | ns_ip_list | IP address(es) not listed as globally reachable: "{ns_ip_list}". | | |
| | A01_DOCUMENTATION_ADDR | ERROR | ns_ip_list | IP address(es) intended for documentation purposes: "{ns_ip_list}". | | |
| | A01_GLOBALLY_REACHABLE_ADDR | INFO | ns_ip_list | Globally reachable IP address(es): "{ns_ip_list}". | | |
| | A01_LOCAL_USE_ADDR | ERROR | ns_ip_list | IP address(es) intended for local use on network or service provider level: "{ns_ip_list}". | | |
| | A01_NO_GLOBALLY_REACHABLE_ADDR | ERROR | | None of the name servers IP address(es) are listed as globally reachable. | | |
| | A01_NO_NAME_SERVERS_FOUND | CRITICAL | | No name servers found. | |
Contributor
There was a problem hiding this comment.
Updated "address" to "address(es)".
matsduf
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Updated specifications for test ADDRESS01
Context
Adds clarifications to bring documentation in line with newer entries
Test scenarios are defined in #1296
Changes
Sections and TOC added. Parts of text reworked.