Restores Basci00#1123
Merged
Merged
Conversation
hannaeko
previously approved these changes
Dec 20, 2022
ghost
previously approved these changes
Dec 20, 2022
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
Apart from a few typos that were probably there before the file was deleted, looks good to me.
| ### Objective | ||
|
|
||
| In order to begin testing the domain name from the input must be a valid | ||
| domain name. The domain name must either be a |
Contributor
There was a problem hiding this comment.
The domain name must either be: (the “a” is redundant”).
| extension of the "_" character, standardized for SRV records | ||
| ([RFC 2782](https://tools.ietf.org/html/rfc2782)). The "." character is | ||
| the delimiter between labels, and a label must not start or end with a | ||
| "-" character. There are also lenght limitation of the domain names and |
Contributor
There was a problem hiding this comment.
“lenght limitation” -> “length limitations”
| section 2.3.2.3), or | ||
| 2. a valid ASCII domain. | ||
|
|
||
| The ASCII domain name is valid if follows the rules defined in section 2.1 |
Contributor
There was a problem hiding this comment.
“if follows” -> “if it follows”
Contributor
Author
The first commit of this PR just restores the file exactly how it was before it was deleted without any changes. |
marc-vanderwal
approved these changes
Dec 23, 2022
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
ghost
approved these changes
Dec 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR #942 removes test case Basic00 as a test case and updates it and turns it into another type of specification ("Requirements and normalization of domain names in input"). The change of implementation has, however, not been completed and Basic00 is still in the implementation.
This PR restores Basic00 specification as a reference for the implementation.
Context
Issue zonemaster/zonemaster-engine#1170
How to test this PR
Review, but this should not updated, just to be kept until the new model has been implemented.