Skip to content

Update specification of Zone01 - #1028#1032

Merged
tgreenx merged 19 commits into
zonemaster:developfrom
tgreenx:patch#1028
Oct 17, 2022
Merged

Update specification of Zone01 - #1028#1032
tgreenx merged 19 commits into
zonemaster:developfrom
tgreenx:patch#1028

Conversation

@tgreenx

@tgreenx tgreenx commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

Purpose

This PR proposes an update to the specification of Zone01 test as described in #1028. The corresponding implementation is provided in another PR (here).

Context

Addresses #1028 and #830

@matsduf

matsduf commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

We should try to have consistent format of the test case specifications. For that purpose there is a template for the specification, Template01.md. Also look at recently created or updated test case specifications such as DNSSEC18 and draft Zone09.

There is also a specification of DNS query (#1000) that has been reviewed, but it requires a final approval. With that the specification can be further standardised.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Apr 12, 2022
@tgreenx tgreenx linked an issue Apr 27, 2022 that may be closed by this pull request
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 18, 2022
@tgreenx

tgreenx commented Aug 3, 2022

Copy link
Copy Markdown
Contributor Author

I have updated this (new) specification to meet the template's requirements. I have done what I can to detail the Test Procedure but that will surely require more work, help appreciated @matsduf .

Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
@tgreenx tgreenx requested a review from matsduf August 4, 2022 13:30
@tgreenx

tgreenx commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

Now that I look more at Zone01 in details (specification and implementation), it appears to be greatly overlapping with this PR, especially when you consider Zone01 title name. And so I can't seem to justify to add this new test case rather than updating Zone01 instead. Wasn't the goal of Zone01 to do just what we are trying to do now? What do you think?

Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone11.md Outdated
@matsduf

matsduf commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Now that I look more at Zone01 in details (specification and implementation), it appears to be greatly overlapping with this PR, especially when you consider Zone01 title name. And so I can't seem to justify to add this new test case rather than updating Zone01 instead. Wasn't the goal of Zone01 to do just what we are trying to do now? What do you think?

I think you are right. I missed that when writing the issue. I agree it is better to update Zone01.

@tgreenx tgreenx changed the title Specification of Zone11 - #1028 Update specification of Zone01 - #1028 Aug 4, 2022
@tgreenx

tgreenx commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

Now that I look more at Zone01 in details (specification and implementation), it appears to be greatly overlapping with this PR, especially when you consider Zone01 title name. And so I can't seem to justify to add this new test case rather than updating Zone01 instead. Wasn't the goal of Zone01 to do just what we are trying to do now? What do you think?

I think you are right. I missed that when writing the issue. I agree it is better to update Zone01.

I have renamed this PR, its content, and the associated issue. Thanks for the comments, I will address them when I can.

@matsduf

matsduf commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

I have renamed this PR, its content, and the associated issue. Thanks for the comments, I will address them when I can.

Also look at the Objective of the current Zone01. It might have references that make sense. The more references the better.

@tgreenx tgreenx requested a review from matsduf September 1, 2022 13:37
Comment thread docs/specifications/tests/Zone-TP/zone01.md
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easier to handle the text in general if lines are kept to 80 characters. From the template:

Limit all lines to 80 characters with the possible exception of tables such as the one in the summary section.

Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
@tgreenx tgreenx requested a review from matsduf September 13, 2022 15:20
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
@tgreenx tgreenx requested a review from matsduf September 22, 2022 15:45
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
@tgreenx tgreenx requested a review from matsduf October 4, 2022 15:45
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
Comment thread docs/specifications/tests/Zone-TP/zone01.md Outdated
@tgreenx tgreenx merged commit f063d83 into zonemaster:develop Oct 17, 2022
@tgreenx tgreenx deleted the patch#1028 branch October 17, 2022 13:08
@tgreenx tgreenx linked an issue Aug 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-TestCase Area: Test case specification or implementation of test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Zone01 specification SOA MNAME '.' due to DNS UPDATEs

2 participants