remove usingnamespace from asyncio #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomano
pushed a commit
that referenced
this pull request
Mar 18, 2025
I tried to remove usingnamespace from ZML and it's deps. Even though `-fincremental` works now, it doesn't provide improved compilation speed. I guess because our compilation time are dominated by the linking of all our C++ deps, and the linking isn't incremental ATM. I split this in 3 pull requests, I find the code a bit uglier everywhere, not sure if it's worth it. * floats.zig this PR * mlir.zig #204 * asyncio.zig #205
e5f3d04 to
aa8348d
Compare
345d66e to
a3b148a
Compare
a3b148a to
42ab7fb
Compare
# Conflicts: # .github/workflows/commit-examples.yaml
42ab7fb to
8c8da42
Compare
8c00355 to
3801943
Compare
hugomano
approved these changes
Jul 21, 2025
gwenzek
added a commit
that referenced
this pull request
Jul 23, 2025
Small PR to remove our last usingnamespace. Also usingnamespace will be out in 0.15.0: ziglang/zig#24362 # Conflicts: # .github/workflows/commit-framework.yaml # .github/workflows/commit.yaml
steeve
pushed a commit
that referenced
this pull request
Aug 26, 2025
Small PR to remove our last usingnamespace. Also usingnamespace will be out in 0.15.0: ziglang/zig#24362
steeve
pushed a commit
that referenced
this pull request
Aug 27, 2025
Small PR to remove our last usingnamespace. Also usingnamespace will be out in 0.15.0: ziglang/zig#24362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to remove our last usingnamespace.
Also usingnamespace will be out in 0.15.0: ziglang/zig#24362