fix(rgb): auto-off logic by elpekenin · Pull Request #2244 · zmkfirmware/zmk

elpekenin · 2024-04-02T18:32:26Z

When going idle or disconnecting USB, the "is RGB on?" state was not properly stored/reverted when waking up, this should fix it.

Cant test it myself as i dont have a RGB board, but according to @awkannan on discord, it works 🤓

awkannan · 2024-04-02T18:36:59Z

I tried a fix without tracking "sleep state" as introduced in this PR, but it didn't work.

My guess was that the event handlers run and call into the rgb_auto function multiple times before ending up in their final state, making our tracking of the previous user state of RGB inaccurate.

Adding the sleep state bits here seems to fix it.

Tested USB auto off behavior as well as idle auto off behavior and both seem to work.

Tested them together, and they both still seem to work as expected, but I was not exhaustive in my testing. In any case - the behavior in this PR is better than what it was before (if it's not already perfect - reasoning about it seems that it should be solid).

Should fix this: #1376

awkannan · 2024-04-02T19:55:12Z

app/src/rgb_underglow.c

+        if (sleep_state.pre_sleep) {
+            return zmk_rgb_underglow_on();
+        } else {
+            return zmk_rgb_underglow_off();


we can probably remove this line / return 0 instead here

(saves a flash write i think?)

If my understanding was correct a few days ago while reading zephyr's docs about settings system, it checks if data is different before writing.

And i think having an explicit off() instrad of return 0 is better because is much more obvious and readable on a quick glance, even though it is equivalent logic-wise.

petejohanson

A few thoughts on the PR. I generally like the approach to harmonize things between the two possible ways the state changes.

@ReFil any thoughts?

app/src/rgb_underglow.c

ReFil · 2024-04-10T21:40:54Z

Haven't got a board to test this on but it looks good

petejohanson

Thanks!

jradtilbrook · 2024-04-25T10:39:33Z

app/src/rgb_underglow.c

    } else {
-        state.on = false;
-        *prev_state = true;
+        sleep_state.rgb_state_before_sleeping = sleep_state.on;


Hey folks, I just ran a build of my firmware with underglow and its now failing. You can see the logs at https://github.com/jradtilbrook/zmk-config/actions/runs/8830708927/job/24244430141?check_suite_focus=true#step:11:143

Looks like the refactor is trying to reference a struct field that is not present to set the rgb status before sleeping.

I think this might need to be updated to

Suggested change

sleep_state.rgb_state_before_sleeping = sleep_state.on;

zmk_rgb_underglow_get_state(&sleep_state.rgb_state_before_sleeping);

Or maybe just

Suggested change

sleep_state.rgb_state_before_sleeping = sleep_state.on;

sleep_state.rgb_state_before_sleeping = sleep.on;

@petejohanson I've created #2284 to remedy this

This fixes a bug introduced in zmkfirmware#2244

This fixes a bug introduced in #2244

This fixes a bug introduced in zmkfirmware#2244

commit c0a3d49 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Mon Feb 12 13:44:56 2024 +0000 fix(split): Update events and init function commit f417665 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Wed Jan 10 13:39:18 2024 +0000 feat(split): Add keymap state sending commit 574ee4e Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Tue Dec 19 12:23:06 2023 +0000 feat(split): Use split data transfer for hid indicators commit a7fb050 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Fri Nov 24 18:32:47 2023 +0000 feat(backlight): Use data transfer framework commit 8d953ab Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Thu Nov 23 23:17:26 2023 +0000 feat(rgb): Use data transfer framework commit 5fc212f Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Thu Nov 23 23:13:35 2023 +0000 fix(split): change peripheral to use work commit ef8ab95 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Tue Nov 21 11:55:45 2023 +0000 feat(split): Add data transfer event commit ff7e0b7 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Tue Nov 21 09:40:56 2023 +0000 feat(split): central to peripheral communication commit 6ed14e9 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Mon Nov 20 13:03:56 2023 +0000 feat(split): raise status changed events on central commit 2ee76be Author: German Gutierrez <GermanG@users.noreply.github.com> Date: Mon May 13 23:43:35 2024 +0200 fix(soft_off): central waits 100ms in split if hold_time enabled commit f0b20c1 Author: Joel Spadin <joelspadin@gmail.com> Date: Fri Oct 13 13:07:55 2023 -0500 feat(boards): Add nRF52 high voltage DC/DC config Added a Kconfig option to enable SOC_DCDC_NRF52X_HV for nice_nano_v2 and mikoto. According to Nordic's documentation, the DC/DC regulator is more efficient than the LDO regulator, so this is enabled by default. The following boards do not support this mode and were not changed: - nice_nano - nice60 - nrfmicro_11, nrfmicro_13 - nrf52840_m2 - bluemicro840 I could not find schematics to confirm whether the following boards support this mode: - bt60_v1, bt60_v2 - bt65_v1 - bt75_v1 - corneish_zen_v1, corneish_zen_v2 - pillbug - puchi_ble_v1 - s40nc commit 8f5c7bb Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 26 05:52:14 2024 +0000 chore(deps): bump pre-commit/action from 3.0.0 to 3.0.1 Bumps [pre-commit/action](https://github.com/pre-commit/action) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/pre-commit/action/releases) - [Commits](pre-commit/action@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: pre-commit/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> commit 7d1f84e Author: Horu <73709188+HigherOrderLogic@users.noreply.github.com> Date: Tue May 14 03:47:33 2024 +0700 chore: fix typos in various places commit 4dfc45d Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Fri May 3 19:17:09 2024 +0100 feat(docs): Document example toggle-mode implementation --------- Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com> commit 2423136 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Fri May 3 08:22:05 2024 +0100 fix(boards): Fix pulls on ZMK uno toggle switch The devicetree pulls always add on to the extra pulls configured by toggle mode, so these should not have pulls defined in the devicetree. Saved ~200uA avg on another board with a 3t toggle switch commit af90882 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed May 1 11:01:32 2024 -0700 fix: Initialize sideband kscan in APPLICATION. * In order to be sure the rest of the system is fully ready before intializing, because init may result in immediate events being triggered when used with toggle direct kscan inner devices. commit d1ad347 Author: German Gutierrez <GermanG@users.noreply.github.com> Date: Mon Apr 29 18:22:40 2024 +0200 fix: shortening keymap_soft_off behavior node * Shorten the soft off node in order for it to work across splits. commit 0d3a4b7 Author: Jarryd Tilbrook <jarryd@tilbrooktech.com> Date: Thu Apr 25 22:26:26 2024 +0800 fix(underglow): Correctly set underglow state This fixes a bug introduced in zmkfirmware#2244 commit 4d56685 Author: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Date: Thu Apr 25 10:55:42 2024 +0200 fix(rgb): auto-off logic commit f4a070a Author: Sadek Baroudi <sadekbaroudi@gmail.com> Date: Sun Apr 21 12:37:47 2024 -0700 fix(boards): nrf boards missing SPI in pinctrl and dtsi, requiring users to manually define in their shield definitions if they wanted to use SPI commit 16e92cf Author: Peter Johanson <peter@peterjohanson.com> Date: Thu Apr 18 06:38:46 2024 +0000 fix(behaviors): Add multiple soft-off instances properly. * Properly pass the node id for the unique soft-off behavior instance when defining it. commit e22bc76 Author: Keeley Hoek <keeley@hoek.io> Date: Sun Apr 7 07:05:51 2024 -0400 fix(hid): Correct off-by-one buffer overflow with NKRO commit a9021de Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Tue Apr 9 10:25:33 2024 -0700 fix(docs): Add wakeup-source to split new shield example commit dfc6dc8 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Tue Feb 27 11:50:54 2024 -0800 fix(docs): Make clear the matrix transform example is incomplete commit 7a51a46 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Tue Feb 27 11:41:46 2024 -0800 feat(docs): Add pointer to shields folder in new shield docs commit 849eca7 Author: Xudong Zheng <7pkvm5aw@slicealias.com> Date: Fri Feb 23 16:59:48 2024 -0500 refactor(underglow): fix uninitialized variable warning

This fixes a bug introduced in zmkfirmware#2244

commit 528b34414f2082ff7ea214d8239fd3ce9eccce27 Author: aaroncorgan <aaron.reeves@corgan.com> Date: Fri Jul 19 13:24:36 2024 -0500 Squashed commit of the following: commit 7bd74a6 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Sat Jul 13 17:31:07 2024 -0700 fix(docs): Add required display-name in physical layout examples commit 8c6bda2 Author: Peter Johanson <peter@peterjohanson.com> Date: Fri Jul 5 15:30:44 2024 -0600 fix: Proper behavior metadata for key repeat/toggle commit 3694ff8 Author: Peter Johanson <peter@peterjohanson.com> Date: Fri Jul 5 12:56:33 2024 -0600 fix: Fix up layer metadata, move to layer IDs. * Studio will use stable layer IDs to refer to layers, so that layer reordering doesn't affect behavior bindings, so update to match. * Fix a few layer metadata entries that missed being refactored. commit e01f13f Author: Peter Johanson <peter@peterjohanson.com> Date: Thu Jul 4 18:26:27 2024 +0000 fix: Fix external power settings load issue. * Because settings load is delayed now, enable external power on init, and let it be disabled on settings load later, to ensure power is on early for other peripheral initialization. Fixes: zmkfirmware#2361 commit 82eed0f Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Jun 5 01:21:34 2024 -0700 feat(boards): Add flash/settings to XIAO RP2040. * Add storage partition. * Default necessacy Kconfig symbols for flash/settings. commit b4f9081 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Jul 3 13:58:08 2024 -0600 docs: Updated new shield documentation for physical layouts. * Document how to define one or more physical layouts and assign the chosen one. Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com> commit 5fcf092 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed May 1 14:07:48 2024 -0700 refactor(shields): Set ZMK Uno physical layouts. * Add physical layout definitions for uno and split uno shields. commit 74f7fe9 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed May 1 14:06:28 2024 -0700 fix(splits): Increase split notify stack size. commit 0438cb0 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Apr 24 21:11:16 2024 -0700 feat(kscan): More complete PM support to drivers. * Update our GPIO kscan drivers to more completely support PM device, by doing proper hardare init/deinit in the PM action hook. commit c5cca5b Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Apr 24 18:14:02 2024 -0700 feat: Add keyboard physical layout system. * Add bindings to allow creating multiple physical layouts that specify their key's physical attributes, and the matching matrix transform and dependant kscan to use. * Synthesize a basic physical layout if none specified, for backwards compatibility. * Update matrix transform API to explicitly pass in the selected transform to the API instead of using a fixed chosen transform. * Move kscan subscription and handling into the physical layout code, so that selecting a different physical layout at runtime can also use the correct kscan instance. * Add `physical_layouts.dtsi` file to include so you can use the pre-configured `&key_physical_attrs` for adding you layout keys. commit 80173f8 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Jul 3 02:33:26 2024 -0600 fix: Improve startup time with proper settings loading. * Avoid doing duplicate calls to setings_load_subtree, which iterates NVS fully each time under the hood, and instead use on settings_load later in the lifecycle. commit f18974e Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Jul 1 18:26:43 2024 +0000 fix: Adjust hid indicator listeners for event refactor * Avoid static listener to prevent subscription issue. commit f2ea1da Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Sun Jun 30 17:59:46 2024 +0100 fix(boards): Suppress devicetree warning nRF5x boards throw a spurious warning for duplicate unit-address when the devicetree gets processed Upstream issue: zephyrproject-rtos/zephyr#29713 Warning suppressed as per: https://docs.zephyrproject.org/latest/build/dts/intro-input-output.html commit 96e55c8 Author: Peter Johanson <peter@peterjohanson.com> Date: Fri Jun 28 17:40:49 2024 -0600 fix: BLE refactor mouse keys fix. commit 483a493 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Apr 17 16:44:22 2024 -0700 feat(behaviors): Add local ID system for behaviors * Add a new feature for tracking a given behavior by a new concept of a "behavior local ID" which is a stable 16-bit identifier for a given behavior, that is resilient to new behaviors being added and requires no additional work on the part of the behavior authors. * Add implementations for either settings lookup table, or CRC16 hashing of behavior device names for generating behavior local IDs. commit f7c34c7 Author: Peter Johanson <peter@peterjohanson.com> Date: Fri Apr 5 16:44:42 2024 +0000 refactor(ble): Extract API to get active profile connection. * Add `struct bt_conn *zmk_ble_active_profile_conn(void)` function for fetching a connection for the current profile. commit b576d52 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Mar 27 22:17:32 2024 +0000 feat(core): Support adding subs to other listeners. * Used for ZMK Studio event remappers to be sure the one RPC event listener subscribes to their mapped events. commit 49f7275 Author: Peter Johanson <peter@peterjohanson.com> Date: Tue Jun 25 11:57:54 2024 -0600 fix: Add metadata to missed behaviors. commit 29599e8 Author: Timoyoungster <timo.proemer04@gmail.com> Date: Fri Jun 14 15:23:37 2024 +0200 docs: hopefully more clear description of the new setting commit 10d03ca Author: Timoyoungster <timo.proemer04@gmail.com> Date: Fri Jun 14 02:28:49 2024 +0200 fix: adding option to separate implicit mod release from key release This adds a new config value `ZMK_HID_SEPARATE_MOD_RELEASE_REPORT` where, if enabled, the report for a key release is sent separately to the accompanying modifier release signals, which are then sent in a second report. This fixes an issue where certain applications are unable to work with implicitly modified keys (e.g. colon) due to them registering the modifier release prior to the actual key release. Have tested this on my personal keyboard and `wev` now shows the signals in the correct order. => **Previously:** ```LSHIFT (pressed) -> colon (pressed) -> LSHIFT (released) -> **semi**colon (released)``` => **Now:** ```LSHIFT (pressed) -> colon (pressed) -> colon (released) -> LSHIFT (released)``` (This time without accidental files) commit 4dce096 Author: honorless <86894501+lesshonor@users.noreply.github.com> Date: Sun Apr 7 18:13:35 2024 -0400 docs: improve settings_reset link commit 9c6d1af Author: honorless <86894501+lesshonor@users.noreply.github.com> Date: Mon Mar 25 14:43:54 2024 -0400 ci(build): limit run scope * Cancel redundant non-nightly runs and jobs dependent on canceled jobs. * Limit scheduled runs to zmkfirmware-owned repos. commit 7c9477b Author: honorless <86894501+lesshonor@users.noreply.github.com> Date: Mon Mar 25 14:26:35 2024 -0400 ci(build): improve security posture * Limit unnecessary permissions. * Avoid storing credentials. commit 0bea783 Author: honorless <86894501+lesshonor@users.noreply.github.com> Date: Mon Mar 25 14:08:19 2024 -0400 ci(build): amend changed-files invocation commit 3e2c428 Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Jun 24 10:58:34 2024 -0600 chore: Add rp2040/USB logging core coverage. * Include an rp2040 core build target, and include USB logging snippet for completeness. commit 03099b0 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Mar 27 12:27:49 2024 -0700 feat(behaviors): Add behavior metadata information. * For upcoming ZMK studio work, make a set of rich metadata available to provide a friendly name for a behavior, and allow super flexible descriptions of the parameters the behaviors take. * Add ability to validate a zmk_behavior_binding against the behavior metadata available. commit 7cdf1e4 Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Jun 24 10:48:21 2024 -0600 fix: Actually add the `zmk-usb-logging` snippet. * D'oh. commit 7be955f Author: Peter Johanson <peter@peterjohanson.com> Date: Fri Jun 21 13:12:13 2024 -0600 fix(usb): Ensure USB init is last * To avoid USB init issues due to other initialization disrupting USB setup, move USB setup to a lower priority. commit a080b52 Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Jun 17 15:39:32 2024 -0600 refactor: Remove static CDC ACM logging nodes. * To avoid spurious CDC ACM instances when usint CDC ACM for something other than logging, move to the approach used by Zephyr of using a snippet to redirect console output to a CDC ACM node added by the snippet. Remove all the existing static CDC ACM nodes. * Add new `zmk-usb-logging` snippet that mirrors the upstream `cdc-acm-logging` snippet, but still does our extra USB logging configuration. * Updated logging docs accordingly. Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com> commit 7c09eb2 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Sun Jun 9 21:35:10 2024 -0700 refactor(docs): Document and enforce header casing conventions commit e56db30 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Sun Jun 9 21:32:26 2024 -0700 refactor(docs): Split up troubleshooting page into a section commit 308d6bc Author: Nicolas Munnich <98408764+Nick-Munnich@users.noreply.github.com> Date: Sun Jun 2 06:51:08 2024 +0200 feat(docs): Improve the toolchain setup page (zmkfirmware#2272) Split the toolchain setup into separate docker and native pages and improve instructions to better refer to Zephyr docs in certain steps. Also refactor to improve consistency and add virtualenv instructions. --------- Co-authored-by: KemoNine <mcrosson@kemonine.info> Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com> commit 2d96f46 Author: Nicolas Munnich <98408764+Nick-Munnich@users.noreply.github.com> Date: Sun May 26 07:16:33 2024 +0200 fix(docs): Removing to-to typos (zmkfirmware#2310) commit 2ee76be Author: German Gutierrez <GermanG@users.noreply.github.com> Date: Mon May 13 23:43:35 2024 +0200 fix(soft_off): central waits 100ms in split if hold_time enabled commit f0b20c1 Author: Joel Spadin <joelspadin@gmail.com> Date: Fri Oct 13 13:07:55 2023 -0500 feat(boards): Add nRF52 high voltage DC/DC config Added a Kconfig option to enable SOC_DCDC_NRF52X_HV for nice_nano_v2 and mikoto. According to Nordic's documentation, the DC/DC regulator is more efficient than the LDO regulator, so this is enabled by default. The following boards do not support this mode and were not changed: - nice_nano - nice60 - nrfmicro_11, nrfmicro_13 - nrf52840_m2 - bluemicro840 I could not find schematics to confirm whether the following boards support this mode: - bt60_v1, bt60_v2 - bt65_v1 - bt75_v1 - corneish_zen_v1, corneish_zen_v2 - pillbug - puchi_ble_v1 - s40nc commit 8f5c7bb Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 26 05:52:14 2024 +0000 chore(deps): bump pre-commit/action from 3.0.0 to 3.0.1 Bumps [pre-commit/action](https://github.com/pre-commit/action) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/pre-commit/action/releases) - [Commits](pre-commit/action@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: pre-commit/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> commit 7d1f84e Author: Horu <73709188+HigherOrderLogic@users.noreply.github.com> Date: Tue May 14 03:47:33 2024 +0700 chore: fix typos in various places commit 4dfc45d Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Fri May 3 19:17:09 2024 +0100 feat(docs): Document example toggle-mode implementation --------- Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com> commit 2423136 Author: ReFil <31960031+ReFil@users.noreply.github.com> Date: Fri May 3 08:22:05 2024 +0100 fix(boards): Fix pulls on ZMK uno toggle switch The devicetree pulls always add on to the extra pulls configured by toggle mode, so these should not have pulls defined in the devicetree. Saved ~200uA avg on another board with a 3t toggle switch commit af90882 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed May 1 11:01:32 2024 -0700 fix: Initialize sideband kscan in APPLICATION. * In order to be sure the rest of the system is fully ready before intializing, because init may result in immediate events being triggered when used with toggle direct kscan inner devices. commit d1ad347 Author: German Gutierrez <GermanG@users.noreply.github.com> Date: Mon Apr 29 18:22:40 2024 +0200 fix: shortening keymap_soft_off behavior node * Shorten the soft off node in order for it to work across splits. commit 0d3a4b7 Author: Jarryd Tilbrook <jarryd@tilbrooktech.com> Date: Thu Apr 25 22:26:26 2024 +0800 fix(underglow): Correctly set underglow state This fixes a bug introduced in zmkfirmware#2244 commit 4d56685 Author: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Date: Thu Apr 25 10:55:42 2024 +0200 fix(rgb): auto-off logic commit f4a070a Author: Sadek Baroudi <sadekbaroudi@gmail.com> Date: Sun Apr 21 12:37:47 2024 -0700 fix(boards): nrf boards missing SPI in pinctrl and dtsi, requiring users to manually define in their shield definitions if they wanted to use SPI commit 16e92cf Author: Peter Johanson <peter@peterjohanson.com> Date: Thu Apr 18 06:38:46 2024 +0000 fix(behaviors): Add multiple soft-off instances properly. * Properly pass the node id for the unique soft-off behavior instance when defining it. commit e22bc76 Author: Keeley Hoek <keeley@hoek.io> Date: Sun Apr 7 07:05:51 2024 -0400 fix(hid): Correct off-by-one buffer overflow with NKRO commit a9021de Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Tue Apr 9 10:25:33 2024 -0700 fix(docs): Add wakeup-source to split new shield example commit dfc6dc8 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Tue Feb 27 11:50:54 2024 -0800 fix(docs): Make clear the matrix transform example is incomplete commit 7a51a46 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Tue Feb 27 11:41:46 2024 -0800 feat(docs): Add pointer to shields folder in new shield docs commit 849eca7 Author: Xudong Zheng <7pkvm5aw@slicealias.com> Date: Fri Feb 23 16:59:48 2024 -0500 refactor(underglow): fix uninitialized variable warning commit dbbeb70 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Apr 10 04:55:14 2024 +0000 feat(mouse): Updated mouse keys docs. commit 0b1d513 Author: Peter Johanson <peter@peterjohanson.com> Date: Tue Apr 9 21:43:07 2024 -0700 fix(mouse): Fix up tests and make ZMK_MOUSE explicit. commit 1974fe9 Author: Peter Johanson <peter@peterjohanson.com> Date: Sun Mar 24 18:30:08 2024 +0000 refactor(mouse): Lots of mouse refactors. * Dedicated mouse source directory. * Split mouse HID into dedicated USB endpoint and HoG service. * Enable composite USB device automatically, tweak the various default sizes. commit 4ea55c3 Author: Peter Johanson <peter@peterjohanson.com> Date: Wed Apr 10 02:13:51 2024 +0000 refactor(mouse): Tweak behavior inclusion, listener code * Always import mouse keys behavior and their associated listeners. * Tweak listener code to only add listener nodes when listener and the associated input device are enabled. commit f446ab4 Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Feb 19 10:23:16 2024 +0000 fix: Testing fixes for listener refactor. commit ca28e83 Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Feb 19 01:55:06 2024 -0800 chore: Minor input behavior clean-up. commit 36c7827 Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Feb 12 20:12:34 2024 +0000 refactor: Proper per-device input listeners. * Buffer data from input devices and only surface to HID once synd'd. commit 3ff6051 Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Dec 11 16:28:31 2023 -0800 fix(mouse): Fixes for logging. * Corrected logging for two-axis input timestamps. commit 664a61e Author: Peter Johanson <peter@peterjohanson.com> Date: Mon Dec 11 15:45:50 2023 -0800 refactor(mouse): Remove mouse work queue, Kconfig * Remove now-unused mouse work queue and related mouse main file. * Move ticks config into a DTS property on the two axis input behavior. commit 368f98c Author: Peter Johanson <peter@peterjohanson.com> Date: Thu Nov 23 22:23:13 2023 +0000 feat(mouse): Add input configs for data mods. * Add ability to swap X/Y, invert X and Y values, and apply a scalar multiplier/divisor. commit 0ba8a29 Author: Peter Johanson <peter@peterjohanson.com> Date: Tue Nov 21 00:30:25 2023 +0000 refactor: Use input system for pointer events. commit 96ad160 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Wed Nov 15 23:41:26 2023 -0800 fix(mouse): Bump up default mouse tick duration to prevent crashes commit 9a68b37 Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Sun Oct 15 23:27:45 2023 -0700 feat(mouse): Split move/scroll & x/y acceleration commit 2eba88d Author: Cem Aksoylar <caksoylar@users.noreply.github.com> Date: Wed Nov 15 21:11:41 2023 -0800 feat(mouse): Add mouse move and scroll support [WIP] Co-authored-by: Alexander Krikun <krikun98@gmail.com> Co-authored-by: Robert U <urob@users.noreply.github.com> Co-authored-by: Shawn Meier <ftc@users.noreply.github.com>

This fixes a bug introduced in zmkfirmware#2244

fix(rgb): auto-off logic

545608d

elpekenin requested a review from a team as a code owner April 2, 2024 18:32

awkannan reviewed Apr 2, 2024

View reviewed changes

petejohanson reviewed Apr 10, 2024

View reviewed changes

app/src/rgb_underglow.c Outdated Show resolved Hide resolved

app/src/rgb_underglow.c Show resolved Hide resolved

fix: naming is hard

a3583c7

petejohanson self-assigned this Apr 11, 2024

petejohanson approved these changes Apr 25, 2024

View reviewed changes

petejohanson merged commit 4d56685 into zmkfirmware:main Apr 25, 2024

elpekenin deleted the fix/rgb_auto_off branch April 25, 2024 09:01

jradtilbrook reviewed Apr 25, 2024

View reviewed changes

jradtilbrook added a commit to jradtilbrook/zmk that referenced this pull request Apr 25, 2024

Correctly set underglow state when entering sleep

2d74ddc

This fixes a bug introduced in zmkfirmware#2244

This was referenced Apr 25, 2024

Correctly set underglow state when entering sleep #2284

Merged

ZMK_RGB_UNDERGLOW_AUTO_OFF_IDLE disregards original on/off underglow state #1376

Open

petejohanson pushed a commit that referenced this pull request Apr 25, 2024

fix(underglow): Correctly set underglow state

0d3a4b7

This fixes a bug introduced in #2244

darknao pushed a commit to darknao/zmk that referenced this pull request May 12, 2024

fix(underglow): Correctly set underglow state

22d1f80

This fixes a bug introduced in zmkfirmware#2244

darknao pushed a commit to darknao/zmk that referenced this pull request May 21, 2024

fix(underglow): Correctly set underglow state

428324c

This fixes a bug introduced in zmkfirmware#2244

darknao mentioned this pull request May 21, 2024

Per key/layer RGB underglow moergo-sc/zmk#30

Closed

EnotionZ pushed a commit to EnotionZ/zmk that referenced this pull request Jun 22, 2024

fix(underglow): Correctly set underglow state

aae65e0

This fixes a bug introduced in zmkfirmware#2244

alan-w-255 pushed a commit to alan-w-255/zmk that referenced this pull request Jun 30, 2024

fix(underglow): Correctly set underglow state

9ad29b0

This fixes a bug introduced in zmkfirmware#2244

not-in-stock pushed a commit to not-in-stock/zmk that referenced this pull request Jul 9, 2024

fix(underglow): Correctly set underglow state

c33b981

This fixes a bug introduced in zmkfirmware#2244

flolbr pushed a commit to flolbr/zmk that referenced this pull request Jul 28, 2024

fix(underglow): Correctly set underglow state

2c73161

This fixes a bug introduced in zmkfirmware#2244

lammai pushed a commit to lammai/zmk that referenced this pull request Oct 27, 2024

fix(underglow): Correctly set underglow state

e510b3d

This fixes a bug introduced in zmkfirmware#2244

earwin pushed a commit to earwin/zmk that referenced this pull request Nov 13, 2024

fix(underglow): Correctly set underglow state

a267c4c

This fixes a bug introduced in zmkfirmware#2244

cfergeau pushed a commit to cfergeau/zmk that referenced this pull request Dec 21, 2024

fix(underglow): Correctly set underglow state

b53ff0e

This fixes a bug introduced in zmkfirmware#2244

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(rgb): auto-off logic#2244

fix(rgb): auto-off logic#2244
petejohanson merged 2 commits intozmkfirmware:mainfrom
elpekenin:fix/rgb_auto_off

elpekenin commented Apr 2, 2024 •

edited

Loading

Uh oh!

awkannan commented Apr 2, 2024 •

edited

Loading

Uh oh!

awkannan Apr 2, 2024

Uh oh!

awkannan Apr 2, 2024

Uh oh!

elpekenin Apr 2, 2024

Uh oh!

petejohanson left a comment

Uh oh!

Uh oh!

Uh oh!

ReFil commented Apr 10, 2024

Uh oh!

petejohanson left a comment

Uh oh!

jradtilbrook Apr 25, 2024

Uh oh!

jradtilbrook Apr 25, 2024

Uh oh!

jradtilbrook Apr 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	sleep_state.rgb_state_before_sleeping = sleep_state.on;
	zmk_rgb_underglow_get_state(&sleep_state.rgb_state_before_sleeping);

Uh oh!

Conversation

elpekenin commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

awkannan commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

awkannan Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

awkannan Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

elpekenin Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

petejohanson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ReFil commented Apr 10, 2024

Uh oh!

petejohanson left a comment

Choose a reason for hiding this comment

Uh oh!

jradtilbrook Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

jradtilbrook Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

jradtilbrook Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

elpekenin commented Apr 2, 2024 •

edited

Loading

awkannan commented Apr 2, 2024 •

edited

Loading