Conversation
Currently, zlib-ng doesn't compile on my machine due to warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss. The non-ascii characters live in zbuild.h. ``` * gcc says: "warning: implicit declaration of function ‘...’" * g++ says: "error: new declaration ‘...’ ambiguates built-in declaration ‘...’" ``` Because zlib-ng treats warning as error, the project doesn't compile. If this warning is disabled, zlib-ng compiles well.
|
Is it possible to remove the character that is none ascii? |
It's a possible solution if maintainers think removing those characters is OK. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1786 +/- ##
============================================
- Coverage 83.34% 33.23% -50.12%
============================================
Files 132 66 -66
Lines 10019 5504 -4515
Branches 2687 1227 -1460
============================================
- Hits 8350 1829 -6521
- Misses 1010 3419 +2409
+ Partials 659 256 -403 ☔ View full report in Codecov by Sentry. |
|
As far as I know full UTF-8 support (without requiring BOM at start of file) only exists in later versions of Windows 10, and Windows 11, so if the file was edited in Windows, it would default to ISO-8859-15 (Latin-15, or Latin-1 + Euro sign), which is the default in a lot of English-speaking countries in Europe. I'm all for making sure the source files either use UTF-8 or 7-bit ASCII, which are safe in all regions except some Asian countries using for example EUC... |
|
What is the characters or lines of code? |
Lines 278-279 in current develop branch... |
|
If it is in a comment, then the comment should be fixed to be ascii characters instead of changing warning flag. |
OK, I'll create a PR to replace non-ascii characters later today. |
Currently, zlib-ng doesn't compile on my machine due to warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss.
The non-ascii characters live in zbuild.h.
Because zlib-ng treats warning as error, the project doesn't compile. If this warning is disabled, zlib-ng compiles well.