Replace non-ascii characters to fix MSVC warning#1791
Merged
Dead2 merged 1 commit intozlib-ng:developfrom Sep 20, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1791 +/- ##
==========================================
Coverage ? 33.21%
==========================================
Files ? 66
Lines ? 5504
Branches ? 1227
==========================================
Hits ? 1828
Misses ? 3411
Partials ? 265 ☔ View full report in Codecov by Sentry. |
nmoinvaz
approved these changes
Sep 19, 2024
Collaborator
|
Even though #1789 should fix the issue for Visual C++, the issue would still exist for other compilers (and even text editors) when UTF-8 locale isn't used. |
Dead2
approved these changes
Sep 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1786 (comment)