don't use zlib-ng's -Wl,--version-script in tests#1750
Merged
Dead2 merged 2 commits intozlib-ng:developfrom Jun 28, 2024
Merged
don't use zlib-ng's -Wl,--version-script in tests#1750Dead2 merged 2 commits intozlib-ng:developfrom
Dead2 merged 2 commits intozlib-ng:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1750 +/- ##
===========================================
- Coverage 83.02% 83.01% -0.01%
===========================================
Files 135 135
Lines 10291 10291
Branches 2783 2783
===========================================
- Hits 8544 8543 -1
Misses 1053 1053
- Partials 694 695 +1 ☔ View full report in Codecov by Sentry. |
lld 18 errors when a version script assigns a version to a symbol that is not defined in the object files. Therefore configure scripts should not use zlib-ng's version script -- all tests will fail. Also test whether the linker supports the flag instead of assuming.
19dc7ad to
ae73e13
Compare
haampie
commented
Jun 22, 2024
Contributor
Author
|
@Dead2 do you do backports for 2.1.x? |
Member
|
@haampie Yes, I was thinking of backporting this to the |
Dead2
pushed a commit
that referenced
this pull request
Jun 28, 2024
lld 18 errors when a version script assigns a version to a symbol that is not defined in the object files. Therefore configure scripts should not use zlib-ng's version script -- all tests will fail. Also test whether the linker supports the flag instead of assuming.
This was referenced Jun 28, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lld 18 errors when a version script assigns a version to a symbol that
is not defined in the object files. Therefore configure scripts should
not use the -Wl,--version-script,zlib.map script -- all tests that create a
dynamic library will fail