Bump rand_core to v0.10; MSRV 1.85#149
Conversation
Cargo.toml
Outdated
| [dev-dependencies] | ||
| blake2b_simd = "1" | ||
| rand = "0.9" | ||
| getrandom = { version = "0.4.0-rc.1", features = ["sys_rng"] } |
There was a problem hiding this comment.
Note: rand hasn't been updated yet, however it seems like you don't need the full rand anyway
There was a problem hiding this comment.
rand v0.10 is out now if you'd prefer that, although this seems like fewer dependencies.
| ] | ||
| edition = "2021" | ||
| rust-version = "1.63" | ||
| rust-version = "1.85" |
There was a problem hiding this comment.
Bumped this because rand_core is a hard dependency and v0.10 carries an MSRV of 1.85 (and has also been bumped to 2024 edition, which could be done in a followup here if desired)
61d3aaf to
de80238
Compare
de80238 to
810bfd0
Compare
NOTE: depends on zkcrypto/ff#149 and forthcoming releases of `rand` and `rand_xorshift` Release notes: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
NOTE: depends on zkcrypto/ff#149 and forthcoming releases of `rand` and `rand_xorshift` Release notes: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
NOTE: depends on zkcrypto/ff#149 and forthcoming releases of `rand` and `rand_xorshift` Release notes: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
NOTE: depends on zkcrypto/ff#149 Release notes for `rand_core` v0.10.0: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
NOTE: depends on zkcrypto/ff#149 Release notes for `rand_core` v0.10.0: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
NOTE: depends on zkcrypto/ff#149 Release notes for `rand_core` v0.10.0: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
|
@str4d How do you feel about such a huge MSRV bump for this? I think we really need to get the mess involving (oh, 1.85 is already MSRV in all the |
|
@ebfull FWIW all of the RustCrypto crates will be bumping MSRV to 1.85 in the forthcoming release |
NOTE: depends on zkcrypto/ff#149 Release notes for `rand_core` v0.10.0: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
bbf3c9a to
9bd5445
Compare
| # Requires #![deny(rustdoc::broken_intra_doc_links)] in crates. | ||
| - run: sudo apt-get -y install libfontconfig1-dev |
There was a problem hiding this comment.
This is no longer installable for whatever reason and breaks the build:
https://github.com/zkcrypto/ff/actions/runs/22320260133/job/64576314383?pr=149
9bd5445 to
dbff4c2
Compare
|
I updated the RFC with the rename for |
Followup to zkcrypto#149, since the name has been changed in zkcrypto/rfcs#1
Followup to zkcrypto#149, since the name has been changed in zkcrypto/rfcs#1
Release notes:
https://github.com/rust-random/rand_core/releases/tag/v0.10.0
Associated
groupPR:zkcrypto/group#71