Room-server: fixed first message letters trim#453
Merged
Conversation
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
hermes-gadget
added a commit
to hermes-gadget/SigurdOS-client
that referenced
this pull request
May 24, 2026
Cherry-picked from zjs81/meshcore-open: - Room-server: fixed first message letters trim (HDDen) - Notification text no longer strips first 4 chars - Signed room-server posts use proper author prefix (roomAuthorPrefix) - isPlain includes isSigned for correct display logic - fourByteRoomContactKey uses actual prefix bytes, not msgText substring Upstream has only 2 new commits vs our fork. Other pre-existing differences (package rename, feature removals, branding) are intentional - we keep our SlopOS identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On room-servers, the first 4 characters of all incoming messages are truncated. Also, sender names was truncated. With this fix, they are now displayed in full again.
How to reproduce: Go to a room server, receive new messages, and check them.
Next, apply the fix and check again. New messages should now appear in full.
This fix was created using Codex: I took the current implementation in meshcore_open and compared it with the implementations from the firmware and meshcore_py. The fix involves aligning the mechanism with the latter two sources.
Screenshot