Conversation
adds a new widget that counts bytes during entry configurable limit and shows user both count and limit provides color feedback use new widget in chat and channel text entry
Owner
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b572314ae9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
|
@446564 Could you please resolve what codex brought up? |
Collaborator
Author
HDDen
added a commit
to HDDen/meshcore-open
that referenced
this pull request
Apr 22, 2026
commit 609d0c8 Author: HDDen <62592944+HDDen@users.noreply.github.com> Date: Wed Apr 22 03:59:43 2026 +0300 Added Cyr2Lat compression by replacing 2-byte cyrillic chars by 1-byte latin commit 6b6a881 Merge: a4bbeff 8ef8a38 Author: zjs81 <30362347+zjs81@users.noreply.github.com> Date: Mon Apr 20 09:17:00 2026 -0700 Merge pull request zjs81#388 from zjs81/msg-chars add byte counted text input commit 8ef8a38 Author: ericz <erics.zimmermann@gmail.com> Date: Sat Apr 18 00:06:03 2026 +0200 change to prepare Outbound Text Functions. commit ddcda4b Author: Enot (ded) Skelly <enot@mailbox.org> Date: Fri Apr 17 14:07:00 2026 -0700 keep multiline editing commit b572314 Author: ericz <erics.zimmermann@gmail.com> Date: Sat Apr 11 18:48:43 2026 +0200 respect smaz encoding in message byte length calculation. commit e97fb9b Author: Enot (ded) Skelly <enot@mailbox.org> Date: Wed Apr 15 08:35:09 2026 -0700 add byte counted text input adds a new widget that counts bytes during entry configurable limit and shows user both count and limit provides color feedback use new widget in chat and channel text entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a new byte counted text input widget
configurable limit and shows user both count and limit
provides color feedback
use new widget in chat and channel text entry
respect smaz encoding byte length in count when active