reimplement location aware snr-indikator after alpha7#299
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reintroduces a location-aware mapping from “direct repeater first-byte” to a concrete Contact (name) for the SNR indicator UI, aligning behavior with the post-alpha7 location features.
Changes:
- Register
path_provider_foundationfor macOS (generated plugin registrant update). - Update
SNRIndicatorto resolve repeater display names via a location-aware contact lookup using the device’s current lat/lon. - Add
getRepeaterPrefixMatchNearLocation(...)helper incontact_search.dartto pick the best repeater/room candidate, optionally using proximity.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| macos/Flutter/GeneratedPluginRegistrant.swift | Adds Path Provider plugin registration for macOS build. |
| lib/widgets/snr_indicator.dart | Uses self location to choose the most relevant repeater contact for display. |
| lib/utils/contact_search.dart | Introduces location-aware repeater/room candidate selection helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Reintroduces a location-aware mapping from repeater SNR entries to Contact names after the alpha7 release, aiming to pick the most relevant repeater contact (optionally near the user’s current location).
Changes:
- Register
path_provider_foundationfor macOS plugin setup. - Update
SNRIndicatorto resolve repeater names via a location-aware contact lookup using the node’s current coordinates. - Add
getRepeaterPrefixMatchNearLocation(...)helper to find repeater/room contacts by pubkey prefix with optional proximity bias.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| macos/Flutter/GeneratedPluginRegistrant.swift | Adds PathProvider plugin registration on macOS. |
| lib/widgets/snr_indicator.dart | Uses self location + new helper to resolve repeater display names. |
| lib/utils/contact_search.dart | Introduces location-aware repeater-prefix contact selection helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ef2194fb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tion anywhere else anymore.
|
I will test and review now |
|
the only issue I can think of is the preference for favorites over snr/distance but that can be a toggle added later |
|
That is not correct: He may check favorites first for searching the nearest, but he will choose the nearest match. Sincerely Eric |
|
oh ya that's just the sorting order of the list, sorry :) |
added in #299 but appears not needed, flutter removes when building
Pull Request for Location aware SNR-Indicator after the alpha7 Release.