fix: Specify flate2 dependency of the deflate-flate2 feature.#345
Merged
Pr0methean merged 3 commits intoMay 10, 2025
Merged
Conversation
This commit helps the CI avoid running into https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args Example failure before this commit can be seen at https://github.com/anforowicz/zip2/actions/runs/14892057603/job/41826536710
Member
|
Thanks! Since this fixes the build in master that's currently broken, I'll merge it as soon as the fuzz tests and DevSkim pass. |
Closed
This was referenced May 12, 2025
Closed
Closed
Merged
cosmicexplorer
pushed a commit
to cosmicexplorer/zip2
that referenced
this pull request
Sep 30, 2025
…p-rs#345) * fix: Specify `flate2` dependency of the `deflate-flate2` feature. Fixes zip-rs#344 * chore: Avoid Clippy's `uninlined_format_args` warning. This commit helps the CI avoid running into https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args Example failure before this commit can be seen at https://github.com/anforowicz/zip2/actions/runs/14892057603/job/41826536710 --------- Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL?
Fixes #344
RE: PR requirements
zip-rs/zip2and notzip-rs/zip-old