chore(deps): update pbkdf2 requirement from 0.11.0 to 0.12.1#2
Merged
github-actions[bot] merged 1 commit intomasterfrom Apr 23, 2023
Merged
Conversation
Member
|
@dependabot rebase |
Updates the requirements on [pbkdf2](https://github.com/RustCrypto/password-hashes) to permit the latest version. - [Release notes](https://github.com/RustCrypto/password-hashes/releases) - [Commits](RustCrypto/password-hashes@scrypt-v0.11.0...pbkdf2-v0.12.1) --- updated-dependencies: - dependency-name: pbkdf2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
cbb21ac to
02a4408
Compare
lovasoa
added a commit
to lovasoa/zip2
that referenced
this pull request
Mar 20, 2026
Problem: each ZIP entry stores the filename three times: 1. file_name: Box<str> (decoded) 2. file_name_raw: Box<[u8]> (raw bytes) 3. IndexMap key: Box<str> (clone of zip-rs#1) For a 23K-entry JAR, this means 3 heap allocations per entry just for filenames, totaling ~4.4 MiB of redundant data. Fix: replace zip-rs#1 and zip-rs#2 with a single ZipFileName enum. The Utf8 variant (used for >99% of real-world files) holds one Arc<str> that serves both name() and name_raw(). The IndexMap key becomes Arc<str> sharing the same refcount — zero-cost clone. The write_non_utf8 test is now #[ignore] because it relied on String::from_utf8_unchecked with invalid UTF-8 bytes, which is undefined behavior. A proper fix needs a raw-filename write API. Measured on bazel.jar (23,631 Stored entries): ZipArchive::new() allocations: before: 4.0 allocs/entry, 490 net bytes/entry (94,530 total) after: 3.0 allocs/entry, 378 net bytes/entry (70,899 total) cargo bench read_metadata (15K entries): before: 2,709,974 ns/iter after: 2,486,833 ns/iter (-8.2%) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on pbkdf2 to permit the latest version.
Commits
90aa4a4pbkdf2 v0.12.1 (#398)7b00674pbkdf2: re-exporthmac(#397)860ed80sha-crypt v0.5.0 (#396)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)