Make distinct error limit configurable by Vexu · Pull Request #17532 · ziglang/zig

Vexu · 2023-10-15T11:27:46Z

I chose to use a CLI argument instead of a const in the root file since changing it would invalidate most functions in an incremental compilation.

Closes #786

Closes ziglang#786

andrewrk

I chose to use a CLI argument instead of a const in the root file since changing it would invalidate most functions in an incremental compilation.

Changing it on the CLI creates an entirely separate cache namespace, so it's essentially the same thing. I don't think it should be a CLI argument.

Vexu · 2023-10-16T05:20:22Z

Making it a const in the root file (or more likely in builtin.zig) requires it to be the first thing analyzed every update and that anything that touches errors depend on that one declaration even when most of the time it would be uncommon to change it while working on something. And unlike the other declarations that can be overwritten there this would change how the language itself worked.

andrewrk

OK, I think you make a fair argument. Let's do the CLI flag then 👍

This flag was added in ziglang#17532 to close ziglang#786, but the language reference was never updated to reflect the change.

andrewrk · 2023-10-20T21:07:03Z

Reverted in 328ec15 due to:

$ grep -IR Type.err_int ../src/
../src/codegen.zig:                        .ty = Type.err_int,
../src/codegen.zig:                        .val = try mod.intValue(Type.err_int, 0),
../src/codegen/llvm.zig:        const rhs = try o.builder.intValue(Builder.Type.err_int, errors_len);
../src/codegen/llvm.zig:            .anyerror_type => Builder.Type.err_int,
../src/codegen/llvm.zig:            => Builder.Type.err_int,
../src/codegen/llvm.zig:                    const error_type = Builder.Type.err_int;
../src/codegen/llvm.zig:                    const error_align = Type.err_int.abiAlignment(mod);
../src/codegen/llvm.zig:                    const error_size = Type.err_int.abiSize(mod);
../src/codegen/llvm.zig:                .error_set_type, .inferred_error_set_type => Builder.Type.err_int,
../src/codegen/llvm.zig:                const llvm_int = try o.builder.intConst(Builder.Type.err_int, int);
../src/codegen/llvm.zig:                    .payload => (try mod.intValue(Type.err_int, 0)).toIntern(),
../src/codegen/llvm.zig:                const error_align = Type.err_int.abiAlignment(mod);
../src/codegen/llvm.zig:                const err_align = Type.err_int.abiAlignment(mod);
../src/codegen/llvm.zig:                _ = try self.wip.ret(try o.builder.intValue(Builder.Type.err_int, 0));
../src/codegen/llvm.zig:                _ = try self.wip.ret(try o.builder.intValue(Builder.Type.err_int, 0));
../src/codegen/llvm.zig:                        try fg.wip.load(.normal, Builder.Type.err_int, err_union, .default, "")
../src/codegen/llvm.zig:                        Builder.Type.err_int,
../src/codegen/llvm.zig:            const zero = try o.builder.intValue(Builder.Type.err_int, 0);
../src/codegen/llvm.zig:        const zero = try o.builder.intValue(Builder.Type.err_int, 0);
../src/codegen/llvm.zig:            break :loaded try self.wip.load(.normal, Builder.Type.err_int, err_field_ptr, .default, "");
../src/codegen/llvm.zig:                return o.builder.intValue(Builder.Type.err_int, 0);
../src/codegen/llvm.zig:            return self.wip.load(.normal, Builder.Type.err_int, operand, .default, "");
../src/codegen/llvm.zig:            return self.wip.load(.normal, Builder.Type.err_int, err_field_ptr, .default, "");
../src/codegen/llvm.zig:        const non_error_val = try o.builder.intValue(Builder.Type.err_int, 0);
../src/codegen/llvm.zig:            const error_alignment = Type.err_int.abiAlignment(mod).toLlvm();
../src/codegen/llvm.zig:        const ok_err_code = try o.builder.intValue(Builder.Type.err_int, 0);
../src/codegen/llvm.zig:            const error_alignment = Type.err_int.abiAlignment(mod).toLlvm();
../src/codegen/llvm.zig:            const error_alignment = Type.err_int.abiAlignment(mod).toLlvm();
../src/codegen/llvm.zig:            const this_tag_int_value = try o.builder.intConst(Builder.Type.err_int, err_int);
../src/codegen/llvm.zig:            try o.builder.fnType(.i1, &.{Builder.Type.err_int}, .normal),
../src/codegen/llvm.zig:        return if (return_type.isError(mod)) Builder.Type.err_int else .void;
../src/codegen/llvm.zig:    return @intFromBool(Type.err_int.abiAlignment(mod).compare(.gt, payload_ty.abiAlignment(mod)));
../src/codegen/llvm.zig:    return @intFromBool(Type.err_int.abiAlignment(mod).compare(.lte, payload_ty.abiAlignment(mod)));
../src/codegen/c.zig:                            Type.err_int,
../src/codegen/c.zig:                            try mod.intValue(Type.err_int, 0),
../src/codegen/c.zig:                        Type.err_int,
../src/codegen/c.zig:                        try mod.intValue(Type.err_int, 0),
../src/codegen/c.zig:                            .ErrorSet => try mod.intValue(Type.err_int, 0),
../src/codegen/c.zig:        TypedValue{ .ty = Type.err_int, .val = try mod.intValue(Type.err_int, 0) }
../src/codegen/c.zig:            try f.object.dg.renderValue(writer, Type.err_int, try mod.intValue(Type.err_int, 0), .Initializer);
../src/codegen/c.zig:        try f.object.dg.renderValue(writer, Type.err_int, try mod.intValue(Type.err_int, 0), .Other);
../src/codegen/c.zig:    try f.object.dg.renderValue(writer, Type.err_int, try mod.intValue(Type.err_int, 0), .Other);
../src/codegen/c.zig:        try f.object.dg.renderValue(writer, Type.err_int, try mod.intValue(Type.err_int, 0), .Other);
../src/codegen/c.zig:        try f.object.dg.renderValue(writer, Type.err_int, try mod.intValue(Type.err_int, 0), .Other);
../src/codegen/c.zig:    try f.object.dg.renderValue(writer, Type.err_int, try mod.intValue(Type.err_int, 0), .Other);
../src/codegen/spirv.zig:                    .payload => Type.err_int,
../src/codegen/spirv.zig:                    .payload => try mod.intValue(Type.err_int, 0),
../src/arch/wasm/CodeGen.zig:                    .ty = Type.err_int,
../src/arch/wasm/CodeGen.zig:                    .val = try mod.intValue(Type.err_int, 0),
../src/arch/wasm/CodeGen.zig:    const errors_len_val = try func.load(errors_len, Type.err_int, 0);
../src/arch/wasm/CodeGen.zig:    const result = try func.cmp(.stack, errors_len_val, Type.err_int, .lt);
../src/Sema.zig:            return mod.undefRef(Type.err_int);
../src/Sema.zig:            Type.err_int,
../src/Sema.zig:                0 => return Air.internedToRef((try mod.intValue(Type.err_int, 0)).toIntern()),
../src/Sema.zig:                    return mod.intRef(Type.err_int, int);
../src/Sema.zig:    return block.addBitCast(Type.err_int, operand);
../src/Sema.zig:    const operand = try sema.coerce(block, Type.err_int, uncasted_operand, operand_src);
../src/Sema.zig:        const zero_val = Air.internedToRef((try mod.intValue(Type.err_int, 0)).toIntern());
../src/Sema.zig:            const err_int = try block.addBitCast(Type.err_int, err_code);
../src/Sema.zig:            const err_int_inst = try block.addBitCast(Type.err_int, operand);

make distinct error limit configurable

8daa41d

Closes ziglang#786

andrewrk requested changes Oct 16, 2023

View reviewed changes

andrewrk approved these changes Oct 16, 2023

View reviewed changes

andrewrk merged commit 78855bd into ziglang:master Oct 16, 2023

Vexu deleted the error-limit branch October 16, 2023 08:10

scheibo added a commit to scheibo/zig that referenced this pull request Oct 19, 2023

langref: update to document --error-limit flag

2d46d1a

This flag was added in ziglang#17532 to close ziglang#786, but the language reference was never updated to reflect the change.

scheibo mentioned this pull request Oct 19, 2023

langref: update to document --error-limit flag #17627

Closed

scheibo added a commit to scheibo/zig that referenced this pull request Oct 20, 2023

langref: update to document --error-limit flag

9f9bfa3

This flag was added in ziglang#17532 to close ziglang#786, but the language reference was never updated to reflect the change.

Vexu mentioned this pull request Oct 21, 2023

Make distinct error limit configurable (attempt #2) #17651

Merged

nektro mentioned this pull request Nov 27, 2023

std.os.dl_iterate_phdr: remove u16 error cast #18144

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make distinct error limit configurable#17532

Make distinct error limit configurable#17532
andrewrk merged 1 commit intoziglang:masterfrom
Vexu:error-limit

Vexu commented Oct 15, 2023

Uh oh!

andrewrk left a comment

Uh oh!

Vexu commented Oct 16, 2023

Uh oh!

andrewrk left a comment

Uh oh!

andrewrk commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Vexu commented Oct 15, 2023

Uh oh!

andrewrk left a comment

Choose a reason for hiding this comment

Uh oh!

Vexu commented Oct 16, 2023

Uh oh!

andrewrk left a comment

Choose a reason for hiding this comment

Uh oh!

andrewrk commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants