Use assertRegex instead of assertRegexpMatches for Python 3.11 compatibility.#104
Merged
twolfson merged 2 commits intozheller:masterfrom Oct 15, 2021
tirkarthi:fix-assert
Merged
Use assertRegex instead of assertRegexpMatches for Python 3.11 compatibility.#104twolfson merged 2 commits intozheller:masterfrom tirkarthi:fix-assert
twolfson merged 2 commits intozheller:masterfrom
tirkarthi:fix-assert
Conversation
Collaborator
|
This is great! Thanks for the PR! =D |
Contributor
Author
|
Thanks for the review. The project had Python 2.7 classifier in setup.py. So I thought Python 2 is supported and added fallback. I guess it's good to drop the classifier and also add python_requires https://packaging.python.org/guides/dropping-older-python-versions/ |
Collaborator
|
Good call on I don't have capacity to pick this up at the moment but I should be able to do that by the end of next weekend |
twolfson
added a commit
that referenced
this pull request
Oct 19, 2021
Collaborator
|
I've updated the classifiers and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecated aliases were removed in Python 3.11 in python/cpython#28268 . Fixes below warnings that are error now.