Conversation
Co-Authored-By: Kirill <kirill@zed.dev>
1 task
rgbkrk
added a commit
that referenced
this pull request
Feb 8, 2026
rgbkrk
added a commit
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases when using the
DealerSocketwhen we need to be able to both continuously send and receive messages without deadlocking either one. For example, with code like this:If we don't get a reply back for that message type we can no longer send out other messages. An approach seen in other code bases is to introduce a
.split()method that breaks up reading and writing. This is a start to that.An alternative would be to make a
try_clonelikeTcpStreamhas which: