Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

set default extras as empty array to prevent compact() errors#170

Closed
kilip wants to merge 3 commits intozendframework:developfrom
kilip:headlink-helper-compact
Closed

set default extras as empty array to prevent compact() errors#170
kilip wants to merge 3 commits intozendframework:developfrom
kilip:headlink-helper-compact

Conversation

@kilip
Copy link
Contributor

@kilip kilip commented Nov 12, 2018 •
edited
Loading

Hello,

PHP compact() function at line 413 will create php error when $args is an empty array:

zend-view/src/Helper/HeadLink.php

Lines 379 to 416 in 34babb4

public function createDataStylesheet(array $args)
{
$rel = 'stylesheet';
$type = 'text/css';
$media = 'screen';
$conditionalStylesheet = false;
$href = array_shift($args);
if ($this->isDuplicateStylesheet($href)) {
return false;
}
if ($args) {
$media = array_shift($args);
if (is_array($media)) {
$media = implode(',', $media);
} else {
$media = (string) $media;
}
}
if ($args) {
$conditionalStylesheet = array_shift($args);
if (! empty($conditionalStylesheet) && is_string($conditionalStylesheet)) {
$conditionalStylesheet = (string) $conditionalStylesheet;
} else {
$conditionalStylesheet = null;
}
}
if ($args && is_array($args[0])) {
$extras = array_shift($args);
$extras = (array) $extras;
}
$attributes = compact('rel', 'type', 'href', 'media', 'conditionalStylesheet', 'extras');
return $this->createData($attributes);
}

I have found this error in this travis build:
https://travis-ci.org/cross-solution/YAWIK/jobs/453775095#L1805
To reproducing error just simply execute this function HeadLink::prependStylesheet('/some/foo.css')

I think this compact() error only occurs in php 7.3, but the code is buggy too. We need to define default value for $extras variables.

froschdesign
froschdesign suggested changes Nov 12, 2018
View reviewed changes
@froschdesign
Copy link
Member

froschdesign commented Nov 12, 2018

Reference for this change in PHP 7.3: http://php.net/manual/en/function.compact.php#refsect1-function.compact-changelog

@froschdesign froschdesign added this to the 2.10.1 milestone Nov 12, 2018
@froschdesign
Copy link
Member

froschdesign commented Nov 12, 2018

Duplicate of #167

@froschdesign froschdesign marked this as a duplicate of #167 Nov 12, 2018
froschdesign
froschdesign reviewed Nov 12, 2018
View reviewed changes
froschdesign
froschdesign reviewed Nov 12, 2018
View reviewed changes
@froschdesign froschdesign mentioned this pull request Nov 12, 2018
Closed
@kilip kilip mentioned this pull request Nov 14, 2018
Open
@froschdesign froschdesign mentioned this pull request Dec 6, 2018
Closed
weierophinney added a commit that referenced this pull request Dec 6, 2018
@weierophinney
Adds CHANGELOG entry for #170
f648a2a
weierophinney added a commit that referenced this pull request Dec 6, 2018
@weierophinney
Merge branch 'hotfix/170-extras-for-compact-op' into develop
8d88806 
Forward port #170
@weierophinney
Copy link
Member

weierophinney commented Dec 6, 2018

Thanks, @kilip - cherry-picked to master, to release with 2.10.1.

@kilip kilip deleted the headlink-helper-compact branch December 9, 2018 05:13
This was referenced May 31, 2021
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@froschdesign froschdesign froschdesign approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

2.10.1

Development

Successfully merging this pull request may close these issues.

3 participants

@kilip @froschdesign @weierophinney