Attributes - Add support for ACE Repair 'Enable' setting#742
Merged
mharis001 merged 5 commits intozen-mod:masterfrom Jan 25, 2024
Merged
Attributes - Add support for ACE Repair 'Enable' setting#742mharis001 merged 5 commits intozen-mod:masterfrom
mharis001 merged 5 commits intozen-mod:masterfrom
Conversation
mharis001
reviewed
Sep 7, 2023
| }; | ||
|
|
||
| if (isClass (configFile >> "CfgPatches" >> "ace_repair")) then { | ||
| if (isClass (configFile >> "CfgPatches" >> "ace_repair") && {missionNamespace getVariable ["ace_repair_enabled", false]}) then { |
Member
There was a problem hiding this comment.
This runs at preInit where settings aren't guaranteed. Likely need to use the condition parameter of the addAttribute function.
Contributor
Author
|
Seems to be working correctly. |
mharis001
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
See acemod/ACE3#8070, setting requires mission restart so should be fine.