Repair - Add enable setting#8070
Merged
LinkIsGrim merged 13 commits intoacemod:masterfrom Jul 29, 2023
Merged
Conversation
veteran29
previously requested changes
Jan 17, 2021
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
LinkIsGrim
requested changes
Jul 15, 2023
Member
LinkIsGrim
left a comment
There was a problem hiding this comment.
setUnitTrait ["Engineer", true] by any third party will break things, but that's a compromise we'll have to make for no item replacements.
LinkIsGrim
reviewed
Jul 15, 2023
rautamiekka
reviewed
Jul 16, 2023
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Contributor
Author
|
Will do also some tests these days after upstream merging. |
LinkIsGrim
reviewed
Jul 16, 2023
LinkIsGrim
reviewed
Jul 16, 2023
LinkIsGrim
reviewed
Jul 16, 2023
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
LinkIsGrim
approved these changes
Jul 17, 2023
3 tasks
PabstMirror
reviewed
Jul 19, 2023
Dystopian
commented
Jul 26, 2023
Member
|
@mharis001 ZEN Engineer Attribute will need to be updated with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Enablesetting toRepairbased on Logistics enable/disable settings (no more compat 🎉) #7040 but with some improvements and without item replacement;B_Truck_01_fuel_F;ACE_isRepairFacilityboolean value handling, see (repair) - isRepairVehicle handling values according to wiki #6278 andACE3/docs/wiki/framework/repair-framework.md
Line 40 in 24b1a71