Skip to content

Fix #3887 and #3558#4167

Merged
mr-cheffy merged 6 commits intozen-browser:devfrom
JosueGalRe:dev
Jan 4, 2025
Merged

Fix #3887 and #3558#4167
mr-cheffy merged 6 commits intozen-browser:devfrom
JosueGalRe:dev

Conversation

@JosueGalRe
Copy link
Member

commit descriptions

- Zen Mods: Default value not being loaded on theme install due to zen mods not being always triggered and default values not being in place when reading them (fixes zen-browser#3887)
- Zen Mods: Fixed string preferences not changing completely by changing the event listener and replacing the throttle with a debounce, so we only listen to the last keydown (fixes zen-browser#3558)
@JosueGalRe JosueGalRe requested a review from mr-cheffy January 4, 2025 03:23
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 4, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 4, 2025
@JosueGalRe JosueGalRe requested a review from mr-cheffy January 4, 2025 15:15
Copy link
Member

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2025
@mr-cheffy mr-cheffy merged commit 4c6b802 into zen-browser:dev Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

2 participants