acp: Support raw agent registry binaries#58579
Merged
Merged
Conversation
It is valid to have raw binary paths in the registry but we didn't handle them.
morgankrey
approved these changes
Jun 4, 2026
Member
Author
|
/cherry-pick preview |
This was referenced Jun 5, 2026
zed-zippy Bot
added a commit
that referenced
this pull request
Jun 5, 2026
…view) (#58632) Cherry-pick of #58579 to preview ---- It is valid to have raw binary paths in the registry but we didn't handle them. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - acp: Fix for certain ACP Registry agent downloads not starting Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
zed-zippy Bot
added a commit
that referenced
this pull request
Jun 5, 2026
…ble) (#58633) Cherry-pick of #58579 to stable ---- It is valid to have raw binary paths in the registry but we didn't handle them. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - acp: Fix for certain ACP Registry agent downloads not starting Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
kylekz
pushed a commit
to kylekz/zed
that referenced
this pull request
Jun 5, 2026
Sync fork up to the latest zed-industries/zed upstream (8ce658f, zed-industries#58579), on top of the previous sync that reached 6bca213 (zed-industries#58037). Resolved conflicts: - crates/zed/src/main.rs: dropped the standalone `git_graph::init(cx)` call because upstream folded the `git_graph` crate into `git_ui` (the `git_ui::init` on the preceding line now invokes `git_graph::init` internally). Kept the fork-only `claude_code_ide::init(cx)` call. Other fork-specific touch points (workspace `Cargo.toml`, `.gitignore` `/claude-code-ext/` entry, `crates/proto/proto/zed.proto` reserved range 10000-10004, `crates/proto/src/proto.rs`, `crates/project/src/project.rs`, `crates/project/src/terminals.rs`, `crates/remote_server/src/headless_project.rs`, `crates/zed/Cargo.toml`, etc.) auto-merged cleanly against upstream's changes; verified the fork additions (claude_code_ide crates, claude_code_ide_dispatcher modules, script/build-fork.ps1, README header, gpui_tokio shim) are intact. Cargo.lock auto-merged; verified with `cargo metadata --locked`.
This was referenced Jun 5, 2026
5 tasks
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
It is valid to have raw binary paths in the registry but we didn't handle them. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - acp: Fix for certain ACP Registry agent downloads not starting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is valid to have raw binary paths in the registry but we didn't
handle them.
Self-Review Checklist:
Release Notes: