Hide markdown code block scrollbar when wrapped#58472
Merged
MrSubidubi merged 4 commits intoJun 4, 2026
Merged
Conversation
MrSubidubi
requested changes
Jun 3, 2026
MrSubidubi
left a comment
Member
There was a problem hiding this comment.
Thanks for this and good find!
Can we make this a bit more robust perhaps? I think it might be better if we could perhaps change this so that code_block_scroll_handle only returns a scroll handle if the code block is not wrapped, so have it return an Option of the scroll handle. That we could then also add a regression test for whilst making the code here a bit cleaner perhaps?
Contributor
Author
|
Did as you asked! Let me know your thoughts please and thanks |
MrSubidubi
approved these changes
Jun 4, 2026
MrSubidubi
left a comment
Member
There was a problem hiding this comment.
Thanks for the fast follow-up!
Quickly hopped on and did three minor cleanups, but nothing bad.
Nice PR and nice find, thank you!
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Follow up of zed-industries#57312. Hides the scrollbar (which does not do anything) when markdown code blocks are wrapped. Release Notes: - Fixed the scrollbar on wrapped code blocks in the agent chat. (As far as I can see the wrap button only exists in the agent chat and not regular markdown previews.) --------- Co-authored-by: MrSubidubi <finn@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Follow up of #57312. Hides the scrollbar (which does not do anything) when markdown code blocks are wrapped.
Release Notes:
(As far as I can see the wrap button only exists in the agent chat and not regular markdown previews.)