mermaid: Fix stack overflow when laying out deeply nested subgraphs#58325
Merged
Conversation
cameron1024
approved these changes
Jun 2, 2026
Member
Author
|
/cherry-pick preview |
zed-zippy Bot
added a commit
that referenced
this pull request
Jun 3, 2026
…58325) (cherry-pick to preview) (#58396) Cherry-pick of #58325 to preview ---- Closes FR-49 This PR fixes stack overflow in flowcharts with deeply nested subgraphs. Rewrote recursive call to iterate with an explicit stack on heap. Added test which reproduces the overflow. We use our fork now, with patch on existing v0.4.0: zed-industries/merman@1c765dc Release Notes: - Fixed a crash in when rendering Mermaid diagram flowcharts with deeply nested subgraphs. Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
dandv
pushed a commit
to dandv/zed
that referenced
this pull request
Jun 3, 2026
…ed-industries#58325) Closes FR-49 This PR fixes stack overflow in flowcharts with deeply nested subgraphs. Rewrote recursive call to iterate with an explicit stack on heap. Added test which reproduces the overflow. We use our fork now, with patch on existing v0.4.0: zed-industries/merman@1c765dc Release Notes: - Fixed a crash in when rendering Mermaid diagram flowcharts with deeply nested subgraphs.
This was referenced Jun 3, 2026
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…ed-industries#58325) Closes FR-49 This PR fixes stack overflow in flowcharts with deeply nested subgraphs. Rewrote recursive call to iterate with an explicit stack on heap. Added test which reproduces the overflow. We use our fork now, with patch on existing v0.4.0: zed-industries/merman@1c765dc Release Notes: - Fixed a crash in when rendering Mermaid diagram flowcharts with deeply nested subgraphs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FR-49
This PR fixes stack overflow in flowcharts with deeply nested subgraphs. Rewrote recursive call to iterate with an explicit stack on heap. Added test which reproduces the overflow.
We use our fork now, with patch on existing v0.4.0: zed-industries/merman@1c765dc
Release Notes: