Skip to content

git: Further extract gitlib2 dependencies#58280

Merged
Anthony-Eid merged 2 commits into
mainfrom
extract-git2-foundations
Jun 1, 2026
Merged

git: Further extract gitlib2 dependencies#58280
Anthony-Eid merged 2 commits into
mainfrom
extract-git2-foundations

Conversation

@Anthony-Eid

Copy link
Copy Markdown
Contributor

Extraction done from #53453

I removed the default Oid implementation we had and added support back for SHA264 back as well. I also removed the hex dependency and just added some of those functions we needed in house so we can avoid building yet another dependency

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • N/A

Extraction done from #53453

I removed the default Oid implementation we had and added support back
for SHA264 back as well. I also removed the hex dependency and just
added some of those functions we needed in house so we can avoid
building yet another dependency
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 1, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 1, 2026
@Anthony-Eid Anthony-Eid added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit e07d9a4 Jun 1, 2026
32 checks passed
@Anthony-Eid Anthony-Eid deleted the extract-git2-foundations branch June 1, 2026 23:52
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
Extraction done from zed-industries#53453

I removed the default Oid implementation we had and added support back
for SHA264 back as well. I also removed the hex dependency and just
added some of those functions we needed in house so we can avoid
building yet another dependency

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants