Skip to content

agent_ui: Show permission popover when inline prompt is above the viewport#58081

Merged
smitbarmase merged 2 commits into
mainfrom
handle-above-viewport-case
May 29, 2026
Merged

agent_ui: Show permission popover when inline prompt is above the viewport#58081
smitbarmase merged 2 commits into
mainfrom
handle-above-viewport-case

Conversation

@smitbarmase

@smitbarmase smitbarmase commented May 29, 2026

Copy link
Copy Markdown
Member

Follow up to #57632, uses changes from #58061

Previously the floating permission popover only appeared when the inline permission prompt was scrolled below the viewport. It now also appears when the prompt is scrolled above the viewport, with the scroll button pointing in the right direction.

Release Notes:

  • Fixed the agent permission popover not appearing when the inline prompt was scrolled above the viewport.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 29, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 29, 2026
@smitbarmase smitbarmase added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 906bff7 May 29, 2026
45 checks passed
@smitbarmase smitbarmase deleted the handle-above-viewport-case branch May 29, 2026 15:14
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
…wport (zed-industries#58081)

Follow up to zed-industries#57632, uses
changes from zed-industries#58061

Previously the floating permission popover only appeared when the inline
permission prompt was scrolled below the viewport. It now also appears
when the prompt is scrolled above the viewport, with the scroll button
pointing in the right direction.

Release Notes:

- Fixed the agent permission popover not appearing when the inline
prompt was scrolled above the viewport.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants