agent_ui: Show global skill paths in edits summary#57767
Merged
MartinYe1234 merged 2 commits intoMay 27, 2026
Conversation
Anthony-Eid
reviewed
May 27, 2026
Comment on lines
+2748
to
+2753
| global_skill_full_path.as_ref().map(|path| { | ||
| Label::new(path.clone()) | ||
| .size(LabelSize::XSmall) | ||
| .buffer_font(cx) | ||
| .ml_1() | ||
| }) |
Contributor
There was a problem hiding this comment.
Could we just fallback to the full path no matter what location path is in? If an agent edits a file I would expect to see the full path instead of an empty icon for basically any case
Contributor
Author
There was a problem hiding this comment.
Yeah that makes sense to me
Member
|
/cherry-pick preview |
Contributor
|
🍒💥 Cherry-pick did not succeed |
MartinYe1234
added a commit
that referenced
this pull request
May 27, 2026
…ick to preview) (#57838) Cherry-pick of #57767 to preview ---- Summary - Display the full path for global skill files in the agent edits summary when they do not have a project-relative file name. Closes AI-320 Validation - cargo check -p agent_ui --lib Release Notes: - Fixed global skill edits appearing without a file path in the agent changes summary. Co-authored-by: MartinYe1234 <52641447+MartinYe1234@users.noreply.github.com>
This was referenced May 27, 2026
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes AI-320
Validation
Release Notes: