Skip to content

Rename agent threads from the sidebar#57656

Merged
MartinYe1234 merged 4 commits into
mainfrom
revert-57654-revert-57521-martin/ai-297-rename-threads-directly-from-the-sidebar
May 26, 2026
Merged

Rename agent threads from the sidebar#57656
MartinYe1234 merged 4 commits into
mainfrom
revert-57654-revert-57521-martin/ai-297-rename-threads-directly-from-the-sidebar

Conversation

@MartinYe1234

@MartinYe1234 MartinYe1234 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Added a rename action for agent threads in the sidebar.
  • Persisted renamed thread titles and kept open thread views in sync.

Release Notes:

  • Improved agent threads by allowing them to be renamed directly from the sidebar.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 25, 2026
@MartinYe1234 MartinYe1234 requested a review from mikayla-maki May 25, 2026 15:51
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 25, 2026
@MartinYe1234 MartinYe1234 self-assigned this May 25, 2026
Comment thread crates/agent/src/thread_store.rs Outdated
})
}

pub fn update_thread_title(

@bennetbo bennetbo May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the changes here, nor the ones in db.
I think at this point we could probably remove the title field from the native agent DB, since we store all titles on the thread metadata store, regardless of which agent they come from.

AFAIK all the logic for renaming should already be in-place (since we support it in the thread view), so this PR should only need touch UI code. Could be that I'm missing something though, happy to pair 😄

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I messed up the PR a bit in that I merged the original before it got a review so this is actually a revert of a revert. In the original Mikayla requested that we update the db first before pushing an update to the UI paths to take care of the case where the workspace would not be fully loaded in.
#57521 (comment)

I would be down to pair on this since I am not as familiar with the direction we want to take this code.

danilo-leal and others added 2 commits May 26, 2026 10:10
@MartinYe1234 MartinYe1234 added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit c551ec9 May 26, 2026
32 checks passed
@MartinYe1234 MartinYe1234 deleted the revert-57654-revert-57521-martin/ai-297-rename-threads-directly-from-the-sidebar branch May 26, 2026 17:57
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
Summary:

- Added a rename action for agent threads in the sidebar.
- Persisted renamed thread titles and kept open thread views in sync.

Release Notes:

- Improved agent threads by allowing them to be renamed directly from
the sidebar.

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants