vim: Fix Helix jump on selected lines#57565
Merged
smitbarmase merged 2 commits intoMay 26, 2026
Merged
Conversation
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Resolves zed-industries#57486 This diff fixes `g w` after selecting lines with `x` in Helix mode. `x` leaves Zed in Helix normal mode with a non-empty selection, but jump target collection treated non-visual selections as ranges to skip. As a result, words on the selected line did not receive jump labels. With this change, Helix normal mode keeps existing selection ranges eligible for jump targets, matching Helix's behavior where normal mode can still carry selections. The regression covers `x` followed by `g w` targeting a word inside the selected line. Release Notes: - Fixed `g w` not targeting words on lines selected with `x` in Helix mode. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #57486
This diff fixes
g wafter selecting lines withxin Helix mode.xleaves Zed in Helix normal mode with a non-empty selection, but jump target collection treated non-visual selections as ranges to skip. As a result, words on the selected line did not receive jump labels.With this change, Helix normal mode keeps existing selection ranges eligible for jump targets, matching Helix's behavior where normal mode can still carry selections. The regression covers
xfollowed byg wtargeting a word inside the selected line.Release Notes:
g wnot targeting words on lines selected withxin Helix mode.