vim: Fix replace in helix select mode#57553
Merged
Merged
Conversation
smitbarmase
approved these changes
May 26, 2026
smitbarmase
left a comment
Member
There was a problem hiding this comment.
Thanks, works as expected.
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Resolves zed-industries#57522 This diff fixes `r` in Helix select mode. The keybinding already pushed the replace operator in `helix_select`, but when the replacement character was typed, the operator dispatch only handled `HelixNormal`, so selected text in `HelixSelect` fell through and cleared the operator without editing the buffer. With this change, Helix select mode uses the same `helix_replace` path as Helix normal mode. Multi-character selections now replace each selected grapheme with the typed character and return to Helix normal mode, matching the existing behaviour for Helix normal selections. Release Notes: - Fixed `r` not replacing multi-character selections in Helix select mode.
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #57522
This diff fixes
rin Helix select mode. The keybinding already pushed the replace operator inhelix_select, but when the replacement character was typed, the operator dispatch only handledHelixNormal, so selected text inHelixSelectfell through and cleared the operator without editing the buffer.With this change, Helix select mode uses the same
helix_replacepath as Helix normal mode. Multi-character selections now replace each selected grapheme with the typed character and return to Helix normal mode, matching the existing behaviour for Helix normal selections.Release Notes:
rnot replacing multi-character selections in Helix select mode.