Skip to content

google: Add Google thinking level support#57358

Merged
benbrandt merged 3 commits into
mainfrom
google-update
May 21, 2026
Merged

google: Add Google thinking level support#57358
benbrandt merged 3 commits into
mainfrom
google-update

Conversation

@benbrandt

Copy link
Copy Markdown
Member

Also makes sure we are properly catching and processing thinking events.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • google: Support thinking levels for Google models.

Also makes sure we are properly catching and processing thinking events.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 21, 2026
@benbrandt benbrandt requested a review from tomhoule May 21, 2026 09:20
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 21, 2026

@tomhoule tomhoule left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goot do me!

@benbrandt benbrandt enabled auto-merge May 21, 2026 09:44
@benbrandt benbrandt added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit b13849d May 21, 2026
32 checks passed
@benbrandt benbrandt deleted the google-update branch May 21, 2026 10:03
@benbrandt

Copy link
Copy Markdown
Member Author

/cherry-pick preview

@zed-zippy

zed-zippy Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/26220031283

zed-zippy Bot added a commit that referenced this pull request May 21, 2026
…eview) (#57377)

Cherry-pick of #57358 to preview

----
Also makes sure we are properly catching and processing thinking events.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX

checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- google: Support thinking levels for Google models.

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
@benbrandt

Copy link
Copy Markdown
Member Author

/cherry-pick stable

zed-zippy Bot added a commit that referenced this pull request May 21, 2026
…able) (#57394)

Cherry-pick of #57358 to stable

----
Also makes sure we are properly catching and processing thinking events.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX

checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- google: Support thinking levels for Google models.

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
Also makes sure we are properly catching and processing thinking events.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- google: Support thinking levels for Google models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants