Skip to content

sidebar: Show pending/unread state in project header when collapsed#57322

Merged
danilo-leal merged 3 commits into
mainfrom
sidebar-pending-collapsed
May 21, 2026
Merged

sidebar: Show pending/unread state in project header when collapsed#57322
danilo-leal merged 3 commits into
mainfrom
sidebar-pending-collapsed

Conversation

@danilo-leal

@danilo-leal danilo-leal commented May 20, 2026

Copy link
Copy Markdown
Member

Closes AI-285

Similar to how we display whether there are running threads or a thread waiting for permission in the collapsed version of the project's header in the sidebar, I was missing the "unread" state from being shown. I had to change the approach here as to how we extract this information because the previous method was relying on observing the state of the list entries within the sidebar at every rebuild_contents run, and given there aren't any list entires when the project is collapsed, it wouldn't work.
Release Notes:

  • Agent: Added the notification indicator on collapsed project headers in the sidebar when a thread completes.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 20, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 20, 2026
@MartinYe1234 MartinYe1234 self-requested a review May 21, 2026 19:27

@MartinYe1234 MartinYe1234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works

@danilo-leal danilo-leal added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 7ec36d3 May 21, 2026
46 checks passed
@danilo-leal danilo-leal deleted the sidebar-pending-collapsed branch May 21, 2026 19:38
pull Bot pushed a commit to Mu-L/zed that referenced this pull request May 21, 2026
…gain (zed-industries#57454)

Quick follow-up to zed-industries#57322. We
weren't removing the pending notification when re-visiting the project
that contains the pending thread (only while the project is still
collapsed, though).

Release Notes:

- N/A
@jean-humann

Copy link
Copy Markdown
Contributor

@danilo-leal quick follow-up question, will it be possible to create something with zed (or through FR) to have this displayed when using a CLI agent in Terminal Thread please ? I can clarify if necessary

jasonsmithio pushed a commit to paddleboarddev/paddleboard that referenced this pull request May 31, 2026
…gain (#57454)

Quick follow-up to zed-industries/zed#57322. We
weren't removing the pending notification when re-visiting the project
that contains the pending thread (only while the project is still
collapsed, though).

Release Notes:

- N/A
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
…ed-industries#57322)

Closes AI-285

Similar to how we display whether there are running threads or a thread
waiting for permission in the collapsed version of the project's header
in the sidebar, I was missing the "unread" state from being shown. I had
to change the approach here as to how we extract this information
because the previous method was relying on observing the state of the
list entries within the sidebar at every `rebuild_contents` run, and
given there aren't any list entires when the project is collapsed, it
wouldn't work.
Release Notes:

- Agent: Added the notification indicator on collapsed project headers
in the sidebar when a thread completes.
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
…gain (zed-industries#57454)

Quick follow-up to zed-industries#57322. We
weren't removing the pending notification when re-visiting the project
that contains the pending thread (only while the project is still
collapsed, though).

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants