zed: Add OpenStatusPage action#57316
Conversation
VisitStatusPage actionVisitStatusPage action
| /// Shows the auto-update notification for testing. | ||
| ShowUpdateNotification, | ||
| /// Visits the Zed status page. | ||
| VisitStatusPage |
There was a problem hiding this comment.
Should we call this OpenStatusPage? That's more in line with similar actions we have like zed: open zed repo.
There was a problem hiding this comment.
I had similar concerns when thinking about adding and adding this due to that, but ultimately decided on going with visit instead of open because to me it felt more fitting in the context. For me, visit conveys the purpose of the operation clearer and I am much more familiar with the phrasing of visiting ones status page as opposed to opening one. That made me ultimately decide on this naming despite it not aligning with existing actions.
There was a problem hiding this comment.
I really think we should stick with the "open" terminology, given that there is a clear precedent for actions that open up a page in the user's browser:
zed: open zed repozed: open docseditor: open urleditor: open permalink to line
There was a problem hiding this comment.
Changed it here.
I do think though that we should think about revisiting our "open" terminology, as this is ambiguous overall: Most of our actions that "open" something do it in Zed, whereas others open a browser. I personally think this is not optimal, since this is a rather big distinction of what happens. E.g., if I only have one window and suddenly my "open" action causes me to switch windows, I'd call that unexpected and not an optimal flow of things from the user perspective too. Perhaps distinguishing these action starting with their naming would help a bit here. At the very least, that was the reason I initially went with the other name
VisitStatusPage actionOpenStatusPage action
Following up on our recent extension outage, this PR adds an action to quickly visit our status page (which with the help of @\gaauwe was recently updated to a more up to date design 🎉 ). While already invokable through the command palette, we can later use this to also add buttons where appropriate for a quick lookup of our current status. Release Notes: - Added the `zed::OpenStatusPage` action to be able to easily visit the Zed status page.
Following up on our recent extension outage, this PR adds an action to quickly visit our status page (which with the help of @\gaauwe was recently updated to a more up to date design 🎉 ).
While already invokable through the command palette, we can later use this to also add buttons where appropriate for a quick lookup of our current status.
Release Notes:
zed::OpenStatusPageaction to be able to easily visit the Zed status page.