Skip to content

google_ai: Support Gemini 3.5 Flash#57299

Merged
rtfeldman merged 1 commit into
mainfrom
tomhoule-rvlzyvotosuy
May 21, 2026
Merged

google_ai: Support Gemini 3.5 Flash#57299
rtfeldman merged 1 commit into
mainfrom
tomhoule-rvlzyvotosuy

Conversation

@tomhoule

@tomhoule tomhoule commented May 20, 2026

Copy link
Copy Markdown
Contributor

Implements the official upgrade instructions for Gemini 3.5 Flash, and adds BYOK support.

The changes about thinking_level and temperature apply to our situation, but they are only recommendations, and we have to support older models, so I preferred not trying to force the preferred / remove the discouraged parameters for now.

temperature becomes optional - we don't fill in a default anymore, since passing it is now discouraged.

This commit also adds support for thinking_level, since it is now preferred to thinking_budget.

FunctionCall and FunctionResponse now support passing an id to properly maintain chain-of-thought preservation and match execution IDs across turns. When resolving incoming tool uses, the mapper prefers the execution ID returned by Gemini, falling back to sequential naming in other scenarios.

Release Notes:

  • Added support for Gemini 3.5 Flash in the Google AI model provider.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 20, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 20, 2026
Comment thread crates/google_ai/src/completion.rs Outdated
@tomhoule tomhoule force-pushed the tomhoule-rvlzyvotosuy branch from 22b3a91 to 46f804a Compare May 20, 2026 18:50
Comment thread crates/google_ai/src/completion.rs Outdated
@tomhoule tomhoule force-pushed the tomhoule-rvlzyvotosuy branch from 46f804a to 0c69f2a Compare May 20, 2026 19:05
Implements the [official upgrade instructions](https://ai.google.dev/gemini-api/docs/whats-new-gemini-3.5#migrate-from-3-flash-preview) for Gemini 3.5 Flash, and adds BYOK support.

For all Gemini 3 and 3.5 series models, the client now utilizes the newer `thinking_level` parameter instead of `thinking_budget` inside the serialized `ThinkingConfig` and avoids serializing the no-longer-recommended parameters `temperature`, `top_p`, and `top_k`.

`FunctionCall` and `FunctionResponse` now support passing an `id` to properly maintain chain-of-thought preservation and match execution IDs across turns. When resolving incoming tool uses, the mapper prefers the execution ID returned by Gemini, falling back to sequential naming in other scenarios.

Release Notes:

- Added support for Gemini 3.5 Flash in the Google AI model provider.
@tomhoule tomhoule force-pushed the tomhoule-rvlzyvotosuy branch from 0c69f2a to 7a5b777 Compare May 20, 2026 19:11
Comment thread crates/google_ai/src/completion.rs
Comment thread crates/google_ai/src/completion.rs
@tomhoule tomhoule marked this pull request as ready for review May 20, 2026 19:22
@tomhoule tomhoule marked this pull request as draft May 20, 2026 19:25
@tomhoule tomhoule marked this pull request as ready for review May 20, 2026 19:27
@rtfeldman rtfeldman enabled auto-merge May 20, 2026 19:54
@rtfeldman rtfeldman added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 4558d14 May 21, 2026
53 of 55 checks passed
@rtfeldman rtfeldman deleted the tomhoule-rvlzyvotosuy branch May 21, 2026 07:40
@benbrandt

Copy link
Copy Markdown
Member

/cherry-pick preview

zed-zippy Bot added a commit that referenced this pull request May 21, 2026
…#57373)

Cherry-pick of #57299 to preview

----
Implements the [official upgrade

instructions](https://ai.google.dev/gemini-api/docs/whats-new-gemini-3.5#migrate-from-3-flash-preview)
for Gemini 3.5 Flash, and adds BYOK support.

The changes about thinking_level and temperature apply to our situation,
but they are only recommendations, and we have to support older models,
so I preferred not trying to force the preferred / remove the
discouraged parameters for now.

`temperature` becomes optional - we don't fill in a default anymore,
since passing it is now discouraged.

This commit also adds support for `thinking_level`, since it is now
preferred to `thinking_budget`.

`FunctionCall` and `FunctionResponse` now support passing an `id` to
properly maintain chain-of-thought preservation and match execution IDs
across turns. When resolving incoming tool uses, the mapper prefers the
execution ID returned by Gemini, falling back to sequential naming in
other scenarios.

Release Notes:

- Added support for Gemini 3.5 Flash in the Google AI model provider.

Co-authored-by: Tom Houlé <13155277+tomhoule@users.noreply.github.com>
@benbrandt

Copy link
Copy Markdown
Member

/cherry-pick stable

zed-zippy Bot added a commit that referenced this pull request May 21, 2026
…57392)

Cherry-pick of #57299 to stable

----
Implements the [official upgrade

instructions](https://ai.google.dev/gemini-api/docs/whats-new-gemini-3.5#migrate-from-3-flash-preview)
for Gemini 3.5 Flash, and adds BYOK support.

The changes about thinking_level and temperature apply to our situation,
but they are only recommendations, and we have to support older models,
so I preferred not trying to force the preferred / remove the
discouraged parameters for now.

`temperature` becomes optional - we don't fill in a default anymore,
since passing it is now discouraged.

This commit also adds support for `thinking_level`, since it is now
preferred to `thinking_budget`.

`FunctionCall` and `FunctionResponse` now support passing an `id` to
properly maintain chain-of-thought preservation and match execution IDs
across turns. When resolving incoming tool uses, the mapper prefers the
execution ID returned by Gemini, falling back to sequential naming in
other scenarios.

Release Notes:

- Added support for Gemini 3.5 Flash in the Google AI model provider.

Co-authored-by: Tom Houlé <13155277+tomhoule@users.noreply.github.com>
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
Implements the [official upgrade
instructions](https://ai.google.dev/gemini-api/docs/whats-new-gemini-3.5#migrate-from-3-flash-preview)
for Gemini 3.5 Flash, and adds BYOK support.

The changes about thinking_level and temperature apply to our situation,
but they are only recommendations, and we have to support older models,
so I preferred not trying to force the preferred / remove the
discouraged parameters for now.

`temperature` becomes optional - we don't fill in a default anymore,
since passing it is now discouraged.

This commit also adds support for `thinking_level`, since it is now
preferred to `thinking_budget`.

`FunctionCall` and `FunctionResponse` now support passing an `id` to
properly maintain chain-of-thought preservation and match execution IDs
across turns. When resolving incoming tool uses, the mapper prefers the
execution ID returned by Gemini, falling back to sequential naming in
other scenarios.

Release Notes:

- Added support for Gemini 3.5 Flash in the Google AI model provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants