Respect max line limit for invisible character replacements#57137
Merged
Conversation
Ensure LineWithInvisibles::from_chunks applies the max line length limit to replacement chunks as well as normal text chunks. Also account for text already flushed into fragments when clipping text. Without this change, pathological lines containing invisible characters could produce unbounded number of line fragments (as was discovered during an OOM error).
smitbarmase
approved these changes
May 20, 2026
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
May 20, 2026
…stries#57137) This change makes sure that `LineWithInvisibles::from_chunks` applies the max line length limit to invisible character replacements as it does to normal text chunks. Without this change, pathological lines containing many invisible characters could produce unbounded number of line fragments. Closes FR-6. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed a rare panic that could occur when lines in the editor contained many invisible characters.
This was referenced May 27, 2026
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
…stries#57137) This change makes sure that `LineWithInvisibles::from_chunks` applies the max line length limit to invisible character replacements as it does to normal text chunks. Without this change, pathological lines containing many invisible characters could produce unbounded number of line fragments. Closes FR-6. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed a rare panic that could occur when lines in the editor contained many invisible characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes sure that
LineWithInvisibles::from_chunksapplies the max line length limit to invisible character replacements as it does to normal text chunks.Without this change, pathological lines containing many invisible characters could produce unbounded number of line fragments.
Closes FR-6.
Self-Review Checklist:
Release Notes: