Make restricted mode more obvious#57056
Merged
Merged
Conversation
macraig
approved these changes
May 18, 2026
yutak03
pushed a commit
to yutak03/zed
that referenced
this pull request
May 19, 2026
…ndustries#57153) Follow up to zed-industries#57056 — This PR ensures we're refreshing the security modal so that it consumes the trust given to the main worktree when creating a new linked (Git) worktree. Release Notes: - N/A
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
May 20, 2026
Closes TRA-150 This PR makes the restricted mode more obvious by: - Immediately opening the restricted mode modal upon opening an untrusted project - Disabling dismissing the modal on escape or click away to force choosing one of the two options (and avoid accidentally staying in restricted mode by simply dismissing it) - Showing the LSP button but with communication about language servers being disabled for untrusted projects - Showing a banner in the project settings with the same communication The motivation for this change was that we tried to be minimal with how we communicate a project is untrusted, but it was so minimal that people were confused as to why language servers and other settings weren't working. It was easy to miss the title bar button, for some reason. The changes in this PR makes it so acting on this decision (trust or not a project) is mandatory in order to even start to interact with the project. I appreciate changes here are more aggressive, but I think it's better to make you think about this decision vs. letting you be confused as to why you don't see LS completions or formatting. Release Notes: - Made restricted mode more obvious, demanding immediate action when opening an untrusted project.
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
May 20, 2026
…ndustries#57153) Follow up to zed-industries#57056 — This PR ensures we're refreshing the security modal so that it consumes the trust given to the main worktree when creating a new linked (Git) worktree. Release Notes: - N/A
This was referenced May 27, 2026
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
Follow up to zed-industries/zed#57056 — This PR ensures we're refreshing the security modal so that it consumes the trust given to the main worktree when creating a new linked (Git) worktree. Release Notes: - N/A
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Closes TRA-150 This PR makes the restricted mode more obvious by: - Immediately opening the restricted mode modal upon opening an untrusted project - Disabling dismissing the modal on escape or click away to force choosing one of the two options (and avoid accidentally staying in restricted mode by simply dismissing it) - Showing the LSP button but with communication about language servers being disabled for untrusted projects - Showing a banner in the project settings with the same communication The motivation for this change was that we tried to be minimal with how we communicate a project is untrusted, but it was so minimal that people were confused as to why language servers and other settings weren't working. It was easy to miss the title bar button, for some reason. The changes in this PR makes it so acting on this decision (trust or not a project) is mandatory in order to even start to interact with the project. I appreciate changes here are more aggressive, but I think it's better to make you think about this decision vs. letting you be confused as to why you don't see LS completions or formatting. Release Notes: - Made restricted mode more obvious, demanding immediate action when opening an untrusted project.
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
…ndustries#57153) Follow up to zed-industries#57056 — This PR ensures we're refreshing the security modal so that it consumes the trust given to the main worktree when creating a new linked (Git) worktree. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TRA-150
This PR makes the restricted mode more obvious by:
The motivation for this change was that we tried to be minimal with how we communicate a project is untrusted, but it was so minimal that people were confused as to why language servers and other settings weren't working. It was easy to miss the title bar button, for some reason. The changes in this PR makes it so acting on this decision (trust or not a project) is mandatory in order to even start to interact with the project. I appreciate changes here are more aggressive, but I think it's better to make you think about this decision vs. letting you be confused as to why you don't see LS completions or formatting.
Release Notes: