git_panel: Add commit history view#56500
Conversation
Anthony-Eid
left a comment
There was a problem hiding this comment.
I wonder if we can unify this code and the git graph
|
Yeah, great call, will give that a pass in a follow up! Landing this one for now 😄 appreciate the review! |
| if self._repo_subscriptions.is_empty() { | ||
| self._repo_subscriptions.push(cx.subscribe( | ||
| active_repository, | ||
| |this, _repo, event, cx| { | ||
| if let RepositoryEvent::GraphEvent(_, _) = event { | ||
| if this.active_tab == GitPanelTab::History { | ||
| this.fetch_commit_history_shas(cx); | ||
| } | ||
| } | ||
| }, | ||
| )); | ||
| self._repo_subscriptions | ||
| .push(cx.observe(active_repository, |_this, _repo, cx| { | ||
| cx.notify(); | ||
| })); | ||
| } |
There was a problem hiding this comment.
I think this is wrong, we should clear the data depending on the type of graph event.
Also, should we have a way to switch the repo when the active repository changes
|
hey, sorry to comment on a merged PR, but since this pertains to UI I wanted get an opinion by Zed design staff: the Git Graph button sitting next to the Uncommit button is risky in case of a mis-click (the buttons being [rightfully] small makes it more susceptible), and [IMO] it looks out of place conceptually too (since the things they do are unrelated) can I ask the design team to consider moving the Git Graph button somewhere else on the pane? I have an alternative place in mind: the graph icon preceding the branch name can be converted into the Git Graph button. what say? 
(I can open a discussion if you want but I thought this was too trivial...) |
…ard (zed-industries#56743) Follow-up to zed-industries#56500. Was missing this ability very much :) Release Notes: - Git Panel: Added the ability to switch between the changes and history tabs with the keyboard.
|
just wanted to swing by and say THANK YOU for this!!! |
…ard (#56743) Follow-up to zed-industries/zed#56500. Was missing this ability very much :) Release Notes: - Git Panel: Added the ability to switch between the changes and history tabs with the keyboard.
This PR adds a history view to the git panel. It draws from similar implementations of commit listing in other places like the file history view and the git graph.
Release Notes: