terminal_view: Hide agent actions in embedded terminal menus#56256
Merged
Conversation
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Resolves zed-industries#56138 This diff hides terminal agent actions from context menus shown by embedded terminal views, such as terminal tool output in agent threads. Those surfaces render through `TerminalView`, but they are not normal interactive terminal panes, and actions like Inline Assist and Add to Agent Thread do not currently resolve the embedded terminal as their target. Previously, choosing Inline Assist from terminal tool output could target the workspace’s active editor instead of the terminal output. The context menu now limits these agent actions to non-embedded terminal views, so regular terminal panes keep their existing behavior while terminal tool output no longer offers actions that cannot resolve to it. Add to Agent Thread _could_ make sense for embedded terminal selections in the future, but it would need explicit target-resolution support for focused embedded terminals. This change keeps that as separate follow-up work instead of leaving a misleading menu item that does not reliably act on the selected tool output. Release Notes: - Fixed embedded terminal context menus showing agent actions that could target the wrong item.
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #56138
This diff hides terminal agent actions from context menus shown by embedded terminal views, such as terminal tool output in agent threads. Those surfaces render through
TerminalView, but they are not normal interactive terminal panes, and actions like Inline Assist and Add to Agent Thread do not currently resolve the embedded terminal as their target.Previously, choosing Inline Assist from terminal tool output could target the workspace’s active editor instead of the terminal output. The context menu now limits these agent actions to non-embedded terminal views, so regular terminal panes keep their existing behavior while terminal tool output no longer offers actions that cannot resolve to it.
Add to Agent Thread could make sense for embedded terminal selections in the future, but it would need explicit target-resolution support for focused embedded terminals. This change keeps that as separate follow-up work instead of leaving a misleading menu item that does not reliably act on the selected tool output.
Release Notes: