markdown: Fix escaping non-ASCII chars#55782
Merged
agu-z merged 2 commits intoMay 19, 2026
Merged
Conversation
agu-z
requested changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Instead of dealing with it at the call site, why don't we just make MarkdownEscaper operate on char?
fn next(&mut self, c: char) -> EscapeActionThat makes the whole class of "low byte of a non-ASCII char looks like punctuation" bugs unrepresentable, instead of relying on callers to pre-validate.
If we do that, we should remove this comment:
zed/crates/markdown/src/markdown.rs
Lines 434 to 435 in 3bd9d13
Contributor
Author
|
Sure, that seems to be a better way, just commited the changes. |
agu-z
approved these changes
May 19, 2026
agu-z
left a comment
Contributor
There was a problem hiding this comment.
Nice! Thank you for your contribution
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
May 20, 2026
Fixes zed-industries#55704 The `escape` function in `crates/markdown/src/markdown.rs` was calling `c as u8` on the `char`s before passing to `MarkdownEscaper::next()`. This strips non ASCII Unicode codepoints down to just their low 8 bits which might be in the ASCII punctuation range and thus cause an extra backslash to be added in front of these non ASCII chars. Release Notes: - Fixed a bug where non-ASCII chars in diagnostic messages were incorrectly rendered with spurious `\` characters
This was referenced May 27, 2026
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Fixes zed-industries#55704 The `escape` function in `crates/markdown/src/markdown.rs` was calling `c as u8` on the `char`s before passing to `MarkdownEscaper::next()`. This strips non ASCII Unicode codepoints down to just their low 8 bits which might be in the ASCII punctuation range and thus cause an extra backslash to be added in front of these non ASCII chars. Release Notes: - Fixed a bug where non-ASCII chars in diagnostic messages were incorrectly rendered with spurious `\` characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55704
The
escapefunction incrates/markdown/src/markdown.rswas callingc as u8on thechars before passing toMarkdownEscaper::next(). This strips non ASCII Unicode codepoints down to just their low 8 bits which might be in the ASCII punctuation range and thus cause an extra backslash to be added in front of these non ASCII chars.Release Notes:
\characters