Skip to content

Use YAML parsing for docker-compose to support legacy podman-compose#55117

Closed
KyleBarton wants to merge 1 commit into
mainfrom
support_docker_compose_yaml_deserialization
Closed

Use YAML parsing for docker-compose to support legacy podman-compose#55117
KyleBarton wants to merge 1 commit into
mainfrom
support_docker_compose_yaml_deserialization

Conversation

@KyleBarton

Copy link
Copy Markdown
Collaborator

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

One note: this adds a crate dependency on serde_yaml, which is deprecated and should be upgraded to serde_yml. However, serde_yaml is already a dependency of the tooling/xtask crate, so I opted to keep dependencies consistent with what's already present. Probably best for a future change to move us to the new serde_yml lib.

Closes #53922

Release Notes:

  • Fixed dev container behavior with legacy podman-compose script

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 28, 2026
@maxdeviant maxdeviant changed the title Use yaml parsing for docker-compose to support legacy podman-compose Use YAML parsing for docker-compose to support legacy podman-compose May 1, 2026
@KyleBarton KyleBarton self-assigned this May 13, 2026
@Veykril Veykril self-requested a review May 13, 2026 19:00
@Veykril Veykril added this pull request to the merge queue May 26, 2026
@Veykril Veykril removed this pull request from the merge queue due to a manual request May 26, 2026
@Veykril

Veykril commented May 26, 2026

Copy link
Copy Markdown
Member

Closing this in favor of just merging #55225

@Veykril Veykril closed this May 26, 2026
@MrSubidubi MrSubidubi deleted the support_docker_compose_yaml_deserialization branch May 26, 2026 07:21
pull Bot pushed a commit to Zezo-Ai/zezo-ai that referenced this pull request May 26, 2026
Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#53486

Note that this builds off of zed-industries#55117 because both touched similar code
areas; I thought it best to in order to avoid conflicts.

Release Notes:

- Added support for local features in dev containers
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#53486

Note that this builds off of zed-industries#55117 because both touched similar code
areas; I thought it best to in order to avoid conflicts.

Release Notes:

- Added support for local features in dev containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev Containers don't support podman-compose

2 participants