Skip to content

agent: Skip serializing empty fields in streaming edit file tool#53510

Merged
bennetbo merged 1 commit intomainfrom
edit-file-tool-do-not-include-fields-on-error-if-empty
Apr 10, 2026
Merged

agent: Skip serializing empty fields in streaming edit file tool#53510
bennetbo merged 1 commit intomainfrom
edit-file-tool-do-not-include-fields-on-error-if-empty

Conversation

@bennetbo
Copy link
Copy Markdown
Member

@bennetbo bennetbo commented Apr 9, 2026

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • N/A or Added/Fixed/Improved ...

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 9, 2026
@bennetbo bennetbo changed the title agent: Skip serialzing empty fields in streaming edit file tool agent: Skip serializing empty fields in streaming edit file tool Apr 9, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Apr 9, 2026
@bennetbo bennetbo requested a review from benbrandt April 9, 2026 11:32
@bennetbo bennetbo merged commit 60fac25 into main Apr 10, 2026
43 checks passed
@bennetbo bennetbo deleted the edit-file-tool-do-not-include-fields-on-error-if-empty branch April 10, 2026 08:00
rtfeldman pushed a commit that referenced this pull request Apr 10, 2026
@bennetbo @rtfeldman
agent: Skip serializing empty fields in streaming edit file tool (#53510
094278b 
)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A or Added/Fixed/Improved ...
@rtfeldman rtfeldman mentioned this pull request Apr 10, 2026
Closed
rtfeldman pushed a commit that referenced this pull request Apr 10, 2026
@bennetbo @rtfeldman
agent: Skip serializing empty fields in streaming edit file tool (#53510
b5bbc66 
)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A or Added/Fixed/Improved ...
@rtfeldman rtfeldman mentioned this pull request Apr 10, 2026
Merged
maxbrunsfeld pushed a commit that referenced this pull request Apr 10, 2026
@bennetbo @maxbrunsfeld
agent: Skip serializing empty fields in streaming edit file tool (#53510
dead189 
)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A or Added/Fixed/Improved ...
maxbrunsfeld added a commit that referenced this pull request Apr 10, 2026
@rtfeldman @danilo-leal
@benbrandt @bennetbo @nathansobo @Anthony-Eid @mikayla-maki @eholk @maxbrunsfeld @cameron1024 @cole-miller @katie-z-geer @ojpro
Cherry-pick fixes for v0.232.x preview patch (#53658)
4802302 
Cherry-picked PRs (in order applied):

1. #53386
2. #53400
3. #53396
4. #53428
5. #53356
6. #53215
7. #53429
8. #53458
9. #53436
10. #53451
11. #53454
12. #53419
13. #53287
14. #53521
15. #53463
16. #52848
17. #53544
18. #53556
19. #53566
20. #53579
21. #53575
22. #53550
23. #53585
24. #53510
25. #53599
26. #53099
27. #53662
28. #53660
29. #53657
30. #53654


Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
Co-authored-by: Nathan Sobo <nathan@zed.dev>
Co-authored-by: Anthony Eid <anthony@zed.dev>
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Co-authored-by: Eric Holk <eric@zed.dev>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Cameron Mcloughlin <cameron.studdstreet@gmail.com>
Co-authored-by: Cole Miller <cole@zed.dev>
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
Co-authored-by: Katie Geer <katie@zed.dev>
Co-authored-by: ojpro <contact@ojpro.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbrandt benbrandt benbrandt approved these changes

Assignees

No one assigned

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bennetbo @benbrandt