Skip to content

agent_ui: Fix "scroll to" buttons#53232

Merged
danilo-leal merged 1 commit intomainfrom
fix-thread-scroll-to-buttons
Apr 6, 2026
Merged

agent_ui: Fix "scroll to" buttons#53232
danilo-leal merged 1 commit intomainfrom
fix-thread-scroll-to-buttons

Conversation

@danilo-leal
Copy link
Copy Markdown
Member

Follow-up to #53101

In the process of fixing the thread view's scroll experience, we for got to turn off the follow state tail for functions that power the scroll buttons in the agent panel.

Release Notes:

  • N/A

@danilo-leal danilo-leal requested a review from mikayla-maki April 6, 2026 12:09
@danilo-leal danilo-leal self-assigned this Apr 6, 2026
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 6, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Apr 6, 2026
@danilo-leal danilo-leal merged commit 1823be5 into main Apr 6, 2026
41 checks passed
@danilo-leal danilo-leal deleted the fix-thread-scroll-to-buttons branch April 6, 2026 19:19
MasoudAlali pushed a commit to MasoudAlali/zed-ide that referenced this pull request Apr 7, 2026
Follow-up to zed-industries#53101

In the process of fixing the thread view's scroll experience, we for got
to turn off the follow state tail for functions that power the scroll
buttons in the agent panel.

Release Notes:

- N/A
KlausUllrich added a commit to KlausUllrich/zed that referenced this pull request Apr 8, 2026
…tion

Port upstream follow_tail refactor (Zed PRs zed-industries#53101, zed-industries#53232) as fresh
feature addition:

- Add FollowMode (pub) + FollowState (internal) enums
- Migrate ListItem::Unmeasured estimated_height → size_hint: Option<Size<Pixels>>
- Add remeasure_items(range) — scoped remeasure preserving size hints
- Add set_follow_mode(), is_following_tail(), scroll_to_end()
- Add follow_state logic to scroll/scroll_by/scroll_to/set_offset_from_scrollbar
- Add auto-scroll + re-engagement in layout_items()
- Add is_following_tail field to ListScrollEvent

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants