editor: Deduplicate sticky header rows#52844
Merged
cole-miller merged 2 commits intozed-industries:mainfrom Mar 31, 2026
Merged
editor: Deduplicate sticky header rows#52844cole-miller merged 2 commits intozed-industries:mainfrom
cole-miller merged 2 commits intozed-industries:mainfrom
Conversation
Member
|
Thanks! |
Member
|
@zed-industries/approved |
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
Fixes a bug that caused duplicate sticky header rows to appear if multiple outline items start on the same row. Sort of addresses zed-industries#52722, although arguably the real issue there is that duplicate outline items are being created in the first place. Before: https://github.com/user-attachments/assets/7941cbe8-9b62-470c-b475-f08f2f20fac6 After: https://github.com/user-attachments/assets/c4e291ea-6414-483f-8ff7-3d89d10000b6 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed a bug that caused duplicate sticky header rows to appear if multiple outline items start on the same row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that caused duplicate sticky header rows to appear if multiple outline items start on the same row.
Sort of addresses #52722, although arguably the real issue there is that duplicate outline items are being created in the first place.
Before:
before.mov
After:
after.mov
Self-Review Checklist:
Release Notes: