Skip to content

sidebar: Add property tests#52540

Merged
mikayla-maki merged 1 commit intomainfrom
sidebar-property-tests
Mar 27, 2026
Merged

sidebar: Add property tests#52540
mikayla-maki merged 1 commit intomainfrom
sidebar-property-tests

Conversation

@Anthony-Eid
Copy link
Copy Markdown
Contributor

@Anthony-Eid Anthony-Eid commented Mar 26, 2026

Context

How to Review

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 26, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Mar 26, 2026
@mikayla-maki mikayla-maki self-assigned this Mar 27, 2026
@Anthony-Eid Anthony-Eid marked this pull request as ready for review March 27, 2026 19:23
@zed-codeowner-coordinator zed-codeowner-coordinator Bot requested review from a team and bennetbo and removed request for a team March 27, 2026 19:23
Comment thread crates/sidebar/src/sidebar.rs Outdated
Copy link
Copy Markdown
Contributor

@eholk eholk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to have property tests now!

@mikayla-maki mikayla-maki force-pushed the sidebar-property-tests branch from db61b35 to 0df8026 Compare March 27, 2026 23:40
@mikayla-maki mikayla-maki enabled auto-merge (squash) March 27, 2026 23:40
@mikayla-maki mikayla-maki merged commit 4cb10df into main Mar 27, 2026
30 checks passed
@mikayla-maki mikayla-maki deleted the sidebar-property-tests branch March 27, 2026 23:46
piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
## Context

<!-- What does this PR do, and why? How is it expected to impact users?
     Not just what changed, but what motivated it and why this approach.

Link to Linear issue (e.g., ENG-123) or GitHub issue (e.g., Closes zed-industries#456)
     if one exists — helps with traceability. -->

## How to Review

<!-- Help reviewers focus their attention:
- For small PRs: note what to focus on (e.g., "error handling in
foo.rs")
- For large PRs (>400 LOC): provide a guided tour — numbered list of
files/commits to read in order. (The `large-pr` label is applied
automatically.)
     - See the review process guidelines for comment conventions -->

## Self-Review Checklist

<!-- Check before requesting review: -->
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A

Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants