agent panel: Fix keybindings on Linux#52479
Closed
OmChillure wants to merge 1 commit intozed-industries:mainfrom
Closed
agent panel: Fix keybindings on Linux#52479OmChillure wants to merge 1 commit intozed-industries:mainfrom
OmChillure wants to merge 1 commit intozed-industries:mainfrom
Conversation
5 tasks
osiewicz
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Context Fixes agent panel keybindings on Linux, mirroring the Windows fix from #43692. On Linux, `Ctrl+Y` (the previous `agent::AllowOnce` binding) is intercepted by the focused text input as "redo", so the shortcut did nothing when the message editor was focused. This is the same issue fixed for Windows in #43692. Changes (Linux and Windows): - `agent::AllowAlways`: added `shift-alt-q` (was unbound on all platforms) - `agent::AllowOnce`: `ctrl-y` → `shift-alt-a` (Linux); already `shift-alt-a` on Windows - `agent::RejectOnce`: `shift-alt-x` on both platforms — `shift-alt-z` conflicted with `agent::RejectAll` bound in other contexts, causing the keybinding hint to not appear in the UI - `agent::ToggleNavigationMenu`: `ctrl-shift-j` → `shift-alt-j` (Linux) - `agent::ToggleOptionsMenu`: `ctrl-alt-i` → `shift-alt-i` (Linux) Closes #52472 ## How to Review Two files changed: `assets/keymaps/default-linux.json` and `assets/keymaps/default-windows.json`. Check the `AgentPanel` context block in each. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Note : Reopens previous work from closed PR #52479 (fork was deleted) Release Notes: - Fixed agent panel `Allow`, `Always Allow`, and `Reject` keybindings not working when the message editor is focused on Linux e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes agent panel keybindings on Linux, mirroring the Windows fix from #43692.
On Linux,
Ctrl+Y(the previousagent::AllowOncebinding) is intercepted by the focused text input as "redo", so the shortcut did nothing when the message editor was focused. This is the same issue fixed for Windows in #43692.Changes (Linux and Windows):
agent::AllowAlways: addedshift-alt-q(was unbound on all platforms)agent::AllowOnce:ctrl-y→shift-alt-a(Linux); alreadyshift-alt-aon Windowsagent::RejectOnce:shift-alt-xon both platforms —shift-alt-zconflicted withagent::RejectAllbound in other contexts, causing the keybinding hint to not appear in the UIagent::ToggleNavigationMenu:ctrl-shift-j→shift-alt-j(Linux)agent::ToggleOptionsMenu:ctrl-alt-i→shift-alt-i(Linux)Closes #52472
How to Review
Two files changed:
assets/keymaps/default-linux.jsonandassets/keymaps/default-windows.json. Check theAgentPanelcontext block in each.Self-Review Checklist
Release Notes:
Allow,Always Allow, andRejectkeybindings not working when the message editor is focused on Linuxe