Skip to content

agent panel: Fix keybindings on Linux#52479

Closed
OmChillure wants to merge 1 commit intozed-industries:mainfrom
OmChillure:linux/fix-agent-panel-keybindings
Closed

agent panel: Fix keybindings on Linux#52479
OmChillure wants to merge 1 commit intozed-industries:mainfrom
OmChillure:linux/fix-agent-panel-keybindings

Conversation

@OmChillure
Copy link
Copy Markdown
Contributor

Context

Fixes agent panel keybindings on Linux, mirroring the Windows fix from #43692.

On Linux, Ctrl+Y (the previous agent::AllowOnce binding) is intercepted by the focused text input as "redo", so the shortcut did nothing when the message editor was focused. This is the same issue fixed for Windows in #43692.

Changes (Linux and Windows):

  • agent::AllowAlways: added shift-alt-q (was unbound on all platforms)
  • agent::AllowOnce: ctrl-yshift-alt-a (Linux); already shift-alt-a on Windows
  • agent::RejectOnce: shift-alt-x on both platforms — shift-alt-z conflicted with agent::RejectAll bound in other contexts, causing the keybinding hint to not appear in the UI
  • agent::ToggleNavigationMenu: ctrl-shift-jshift-alt-j (Linux)
  • agent::ToggleOptionsMenu: ctrl-alt-ishift-alt-i (Linux)

Closes #52472

How to Review

Two files changed: assets/keymaps/default-linux.json and assets/keymaps/default-windows.json. Check the AgentPanel context block in each.

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed agent panel Allow, Always Allow, and Reject keybindings not working when the message editor is focused on Linux
    e

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 26, 2026
@zed-community-bot zed-community-bot bot added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Mar 26, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, ConradIrwin and nathansobo and removed request for a team March 26, 2026 09:31
@OmChillure OmChillure closed this by deleting the head repository Mar 29, 2026
osiewicz pushed a commit that referenced this pull request Mar 30, 2026
## Context

Fixes agent panel keybindings on Linux, mirroring the Windows fix from
#43692.

On Linux, `Ctrl+Y` (the previous `agent::AllowOnce` binding) is
intercepted by the focused text input as "redo", so the shortcut did
nothing when the message editor was focused. This is the same issue
fixed for Windows in #43692.

Changes (Linux and Windows):
- `agent::AllowAlways`: added `shift-alt-q` (was unbound on all
platforms)
- `agent::AllowOnce`: `ctrl-y` → `shift-alt-a` (Linux); already
`shift-alt-a` on Windows
- `agent::RejectOnce`: `shift-alt-x` on both platforms — `shift-alt-z`
conflicted with `agent::RejectAll` bound in other contexts, causing the
keybinding hint to not appear in the UI
- `agent::ToggleNavigationMenu`: `ctrl-shift-j` → `shift-alt-j` (Linux)
- `agent::ToggleOptionsMenu`: `ctrl-alt-i` → `shift-alt-i` (Linux)

Closes #52472

## How to Review

Two files changed: `assets/keymaps/default-linux.json` and
`assets/keymaps/default-windows.json`. Check the `AgentPanel` context
block in each.

## Self-Review Checklist

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable


Note : Reopens previous work from closed PR #52479 (fork was deleted)

Release Notes:

- Fixed agent panel `Allow`, `Always Allow`, and `Reject` keybindings
not working when the message editor is focused on Linux
e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent panel: Can't use keyboard shortcut to accept tool commands while the input box is focused

3 participants