Skip to content

Dev containers native implementation#52338

Merged
KyleBarton merged 79 commits intomainfrom
dev_containers_native_implementation
Apr 1, 2026
Merged

Dev containers native implementation#52338
KyleBarton merged 79 commits intomainfrom
dev_containers_native_implementation

Conversation

@KyleBarton
Copy link
Copy Markdown
Collaborator

@KyleBarton KyleBarton commented Mar 24, 2026

Context

Closes #11473

In-house Zed implementation of devcontainers. Replaces the dependency on the reference implementation via Node.

This enables additional features with this implementation:

  1. Zed extensions can be specified in the customizations block, via this syntax in `devcontainer.json:
...
  "customizations": {
    "zed": {
      "extensions": ["vue", "ruby"],
    },
  },

  1. forwardPorts are supported for multiple ports proxied to the host

How to Review

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Improved devcontainer implementation by moving initialization and creation in-house

KyleBarton and others added 30 commits February 9, 2026 08:52
@KyleBarton KyleBarton enabled auto-merge (squash) April 1, 2026 15:14
@KyleBarton KyleBarton disabled auto-merge April 1, 2026 15:14
@KyleBarton KyleBarton merged commit 3eadd41 into main Apr 1, 2026
30 checks passed
@KyleBarton KyleBarton deleted the dev_containers_native_implementation branch April 1, 2026 15:16
@KyleBarton KyleBarton mentioned this pull request Apr 1, 2026
@KyleBarton
Copy link
Copy Markdown
Collaborator Author

/cherry-pick v0.231.x

@zed-zippy
Copy link
Copy Markdown
Contributor

zed-zippy bot commented Apr 1, 2026

⚠️ Expected /cherry-pick stable or /cherry-pick preview

@KyleBarton
Copy link
Copy Markdown
Collaborator Author

/cherry-pick preview

@zed-zippy
Copy link
Copy Markdown
Contributor

zed-zippy bot commented Apr 1, 2026

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/23856620328

KyleBarton added a commit that referenced this pull request Apr 1, 2026
## Context

Closes #11473

In-house Zed implementation of devcontainers. Replaces the dependency on
the [reference implementation](https://github.com/devcontainers/cli) via
Node.

This enables additional features with this implementation:
1. Zed extensions can be specified in the `customizations` block, via
this syntax in `devcontainer.json:
```
...
  "customizations": {
    "zed": {
      "extensions": ["vue", "ruby"],
    },
  },

```
2.
[forwardPorts](https://containers.dev/implementors/json_reference/#general-properties)
are supported for multiple ports proxied to the host

## How to Review

<!-- Help reviewers focus their attention:
- For small PRs: note what to focus on (e.g., "error handling in
foo.rs")
- For large PRs (>400 LOC): provide a guided tour — numbered list of
files/commits to read in order. (The `large-pr` label is applied
automatically.)
     - See the review process guidelines for comment conventions -->

## Self-Review Checklist

<!-- Check before requesting review: -->
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Improved devcontainer implementation by moving initialization and
creation in-house
@zed-zippy zed-zippy bot added the PR state:needs review Used to label PRs that are in need of a post-merge approval label Apr 4, 2026
@ConradIrwin
Copy link
Copy Markdown
Member

@zed-zippy approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement large-pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev Containers

4 participants