Skip to content

gpui: Ensure global keybinds do not have a too high precedence in some cases#52275

Draft
MrSubidubi wants to merge 2 commits intomainfrom
settings-toggle-fix
Draft

gpui: Ensure global keybinds do not have a too high precedence in some cases#52275
MrSubidubi wants to merge 2 commits intomainfrom
settings-toggle-fix

Conversation

@MrSubidubi
Copy link
Copy Markdown
Member

Context

This fixes an issue we were seeing where global keybindings would take precedence over keybinds with a context that would match a context higher up in the key context stack.

Self-Review Checklist

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed an issue where global keybindings would take precedence over keybinds with a context that matched a key context higher up in the key context stack. E.g., if your keybind had the context Pane and the current key context would be Pane > Editor, any global keybind with the same keys would take precedence. This is now fixed.

@MrSubidubi MrSubidubi self-assigned this Mar 24, 2026
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 24, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Mar 24, 2026
@MrSubidubi MrSubidubi marked this pull request as ready for review March 24, 2026 00:17
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, as-cii and dinocosta and removed request for a team March 24, 2026 00:17
@MrSubidubi MrSubidubi marked this pull request as draft March 24, 2026 00:49
MrSubidubi added a commit that referenced this pull request Mar 24, 2026
Solves an issue introduced by
#49527 until we land
#52275.

No release notes since this is only on Nightly.

Release Notes:

- N/A
@zelenenka zelenenka removed the Size S label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants