languages: Improve semantic token highlighting for parameters and Python#52130
Merged
SomeoneToIgnore merged 6 commits intozed-industries:mainfrom Mar 23, 2026
Merged
languages: Improve semantic token highlighting for parameters and Python#52130SomeoneToIgnore merged 6 commits intozed-industries:mainfrom
SomeoneToIgnore merged 6 commits intozed-industries:mainfrom
Conversation
SomeoneToIgnore
requested changes
Mar 22, 2026
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Given that something visual is changed in this PR and we have https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#sending-changes , please add before/after screenshots.
Contributor
Author
|
I've attached a side-by-side comparison to show the rendering changes, where the old behavior is on the left and the new version is on the right. The examples include Python using the ty language server and Rust with rust-analyzer. I used red boxes and labels to highlight exactly how specific token types and modifiers—like docstrings, cls/self parameters, and constants—are now being handled. This should cover all the visual updates I made in this PR, and I apologize for not providing these screenshots in the initial submission. 
|
SomeoneToIgnore
approved these changes
Mar 23, 2026
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Thank you a lot!
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 23, 2026
…hon (zed-industries#52130) ## Context Zed's semantic token highlighting does not cover all token types returned by language servers, so the highlighting looks fairly primitive compared with tree-sitter highlighting, especially for Python language servers. This PR adds some global and Python-specific rules for better highlighting. I need to admit that the built-in Python language servers currently have weak semantic highlighting implementations. Pylance, the closed-source Python language server from Microsoft, provides the best highlighting for now, but I think ty will do better, even though it still has a long way to go. ## How to Review Basically, this is a rule-adding change. Some rules are made global, and some are made Python-specific. ## Self-Review Checklist <!-- Check before requesting review: --> - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Improved semantic token highlighting for parameters and Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Zed's semantic token highlighting does not cover all token types returned by language servers, so the highlighting looks fairly primitive compared with tree-sitter highlighting, especially for Python language servers. This PR adds some global and Python-specific rules for better highlighting.
I need to admit that the built-in Python language servers currently have weak semantic highlighting implementations. Pylance, the closed-source Python language server from Microsoft, provides the best highlighting for now, but I think ty will do better, even though it still has a long way to go.
How to Review
Basically, this is a rule-adding change. Some rules are made global, and some are made Python-specific.
Self-Review Checklist
Release Notes: