markdown_preview: Refactor to use shared markdown crate#52008
Merged
smitbarmase merged 12 commits intomainfrom Mar 26, 2026
Merged
markdown_preview: Refactor to use shared markdown crate#52008smitbarmase merged 12 commits intomainfrom
smitbarmase merged 12 commits intomainfrom
Conversation
This was referenced Mar 20, 2026
mac9sb
added a commit
to mac9sb/zed
that referenced
this pull request
Mar 23, 2026
Merge the markdown preview refactor (PR zed-industries#52008) which replaces the custom markdown_elements/markdown_parser/markdown_renderer modules with the shared markdown crate. Port the navigation features (link click behavior settings, back/forward nav history, navigate-to-markdown-file) to work with the new MarkdownElement API.
This was referenced Mar 23, 2026
8752ef7 to
774f03a
Compare
📏 PR Size: 8278 lines changed (Size XL)Please note: this PR exceeds the 400 LOC soft limit.
|
1ab80cc to
d423928
Compare
d423928 to
6798ec4
Compare
osiewicz
approved these changes
Mar 26, 2026
|
Closes #16727 |
1 task
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the parser and renderer from the
markdowncrate for Markdown Preview, instead of maintaining two separate code paths.How it works:
markdown_preview_view.rsis now a consumer ofMarkdownElement. It acts as a thin wrapper, handling things like resolving URL clicks and image URLs, which can vary between consumers. It also handles syncing the editor selection with the active block in the preview. The APIs for this are provided byMarkdownElement.All the heavy lifting like parsing HTML, rendering block markers on hover, handling the active block, etc. is done by
MarkdownElement. Everything is opt-in. For example, markdown in the Agent Panel can choose not to enable block marker rendering or HTML parsing, while Markdown Preview opts into those features.Final outcome:
For Markdown Preview View:
Added:
Stays:
For the
markdowncrate:Release Notes: