Skip to content

git_ui: Add starts_open setting to git panel#51601

Merged
SomeoneToIgnore merged 2 commits intozed-industries:mainfrom
mvanhorn:osc/51542-git-panel-starts-open
Mar 18, 2026
Merged

git_ui: Add starts_open setting to git panel#51601
SomeoneToIgnore merged 2 commits intozed-industries:mainfrom
mvanhorn:osc/51542-git-panel-starts-open

Conversation

@mvanhorn
Copy link
Copy Markdown
Contributor

@mvanhorn mvanhorn commented Mar 15, 2026

Fixes #51542

Adds a git_panel.starts_open setting for parity with project_panel. When set to true, the git panel opens automatically in new workspaces that don't have saved panel state.

The default is false, matching current behavior (non-breaking).

Usage

{
  "git_panel": {
    "starts_open": true
  }
}

Implementation

Follows the same pattern as project_panel.starts_open:

  1. GitPanelSettingsContent - added starts_open: Option<bool> to the settings schema
  2. GitPanelSettings - added starts_open: bool field
  3. GitPanel Panel impl - overrides starts_open() to read from settings

Release Notes:

  • Added git_panel.starts_open setting to control whether the git panel opens automatically in new workspaces (default: false)

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 15, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @mvanhorn on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 15, 2026
@mvanhorn
Copy link
Copy Markdown
Contributor Author

mvanhorn commented Mar 15, 2026

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 15, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @mvanhorn on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 15, 2026

The cla-bot has been summoned, and re-checked this pull request!

@mvanhorn
Copy link
Copy Markdown
Contributor Author

mvanhorn commented Mar 15, 2026

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 15, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 15, 2026

The cla-bot has been summoned, and re-checked this pull request!

SomeoneToIgnore
SomeoneToIgnore reviewed Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this needs a rebase and a change in all-settings.md , otherwise looks good.

@SomeoneToIgnore SomeoneToIgnore self-assigned this Mar 17, 2026
@mvanhorn
git_ui: Add starts_open setting to git panel
ef020c9 
Fixes zed-industries#51542

Adds a `git_panel.starts_open` setting (default: false) for parity with
project_panel. When set to true, the git panel opens automatically in
new workspaces.
@mvanhorn mvanhorn force-pushed the osc/51542-git-panel-starts-open branch from 1ba6473 to ef020c9 Compare March 17, 2026 14:47
@mvanhorn
Copy link
Copy Markdown
Contributor Author

mvanhorn commented Mar 17, 2026

Rebased onto main and added starts_open to all-settings.md (both the JSON example and options list) in ef020c9.

SomeoneToIgnore
SomeoneToIgnore approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) March 17, 2026 15:09
SomeoneToIgnore
SomeoneToIgnore reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there's no new entry in default.json (would be good to have the comment on it, similar as all other entries have there) which causes the tests to fail.

@mvanhorn @claude
git_ui: Add starts_open to default.json
ddaef02 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mvanhorn
Copy link
Copy Markdown
Contributor Author

mvanhorn commented Mar 18, 2026

Added starts_open to default.json with the comment in ddaef02. Tests should pass now.

@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) March 18, 2026 15:07
@SomeoneToIgnore SomeoneToIgnore merged commit 00bee45 into zed-industries:main Mar 18, 2026
29 checks passed
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 18, 2026
@mvanhorn @claude @AmaanBilwar
git_ui: Add starts_open setting to git panel (zed-industries#51601)
666f834 
Fixes zed-industries#51542

Adds a `git_panel.starts_open` setting for parity with `project_panel`.
When set to `true`, the git panel opens automatically in new workspaces
that don't have saved panel state.

The default is `false`, matching current behavior (non-breaking).

### Usage

```json
{
  "git_panel": {
    "starts_open": true
  }
}
```

### Implementation

Follows the same pattern as `project_panel.starts_open`:

1. `GitPanelSettingsContent` - added `starts_open: Option<bool>` to the
settings schema
2. `GitPanelSettings` - added `starts_open: bool` field
3. `GitPanel` Panel impl - overrides `starts_open()` to read from
settings

Release Notes:

- Added `git_panel.starts_open` setting to control whether the git panel
opens automatically in new workspaces (default: false)

---------

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kczx3 kczx3 mentioned this pull request Mar 18, 2026
Merged
@mvanhorn
Copy link
Copy Markdown
Contributor Author

mvanhorn commented Mar 19, 2026

Thanks for the merge.

AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 20, 2026
@mvanhorn @claude @AmaanBilwar
git_ui: Add starts_open setting to git panel (zed-industries#51601)
3d32eb0 
Fixes zed-industries#51542

Adds a `git_panel.starts_open` setting for parity with `project_panel`.
When set to `true`, the git panel opens automatically in new workspaces
that don't have saved panel state.

The default is `false`, matching current behavior (non-breaking).

### Usage

```json
{
  "git_panel": {
    "starts_open": true
  }
}
```

### Implementation

Follows the same pattern as `project_panel.starts_open`:

1. `GitPanelSettingsContent` - added `starts_open: Option<bool>` to the
settings schema
2. `GitPanelSettings` - added `starts_open: bool` field
3. `GitPanel` Panel impl - overrides `starts_open()` to read from
settings

Release Notes:

- Added `git_panel.starts_open` setting to control whether the git panel
opens automatically in new workspaces (default: false)

---------

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
toshmukhamedov pushed a commit to toshmukhamedov/zed that referenced this pull request Mar 20, 2026
@mvanhorn @claude @toshmukhamedov
git_ui: Add starts_open setting to git panel (zed-industries#51601)
b0647f3 
Fixes zed-industries#51542

Adds a `git_panel.starts_open` setting for parity with `project_panel`.
When set to `true`, the git panel opens automatically in new workspaces
that don't have saved panel state.

The default is `false`, matching current behavior (non-breaking).

### Usage

```json
{
  "git_panel": {
    "starts_open": true
  }
}
```

### Implementation

Follows the same pattern as `project_panel.starts_open`:

1. `GitPanelSettingsContent` - added `starts_open: Option<bool>` to the
settings schema
2. `GitPanelSettings` - added `starts_open: bool` field
3. `GitPanel` Panel impl - overrides `starts_open()` to read from
settings

Release Notes:

- Added `git_panel.starts_open` setting to control whether the git panel
opens automatically in new workspaces (default: false)

---------

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmaanBilwar pushed a commit to AmaanBilwar/zed that referenced this pull request Mar 23, 2026
@mvanhorn @claude @AmaanBilwar
git_ui: Add starts_open setting to git panel (zed-industries#51601)
238d58e 
Fixes zed-industries#51542

Adds a `git_panel.starts_open` setting for parity with `project_panel`.
When set to `true`, the git panel opens automatically in new workspaces
that don't have saved panel state.

The default is `false`, matching current behavior (non-breaking).

### Usage

```json
{
  "git_panel": {
    "starts_open": true
  }
}
```

### Implementation

Follows the same pattern as `project_panel.starts_open`:

1. `GitPanelSettingsContent` - added `starts_open: Option<bool>` to the
settings schema
2. `GitPanelSettings` - added `starts_open: bool` field
3. `GitPanel` Panel impl - overrides `starts_open()` to read from
settings

Release Notes:

- Added `git_panel.starts_open` setting to control whether the git panel
opens automatically in new workspaces (default: false)

---------

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nullstalgia nullstalgia mentioned this pull request Apr 2, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore approved these changes

Assignees

@SomeoneToIgnore SomeoneToIgnore

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add starts_open setting to git_panel (and other dock panels) for parity with project_panel

2 participants

@mvanhorn @SomeoneToIgnore